Starshells still visible, please help!

[vdr1981]

Originally Posted by volodya61

All I can say I already said - http://www.subsim.com/radioroom/show...postcount=1090

OK then... Here's entry from IRAI patch1, can you see something strange then?

# Edited by TheDarkWraith for IRAI_0_0_40
# Edited on 2/11/2013 @ 1700

# Copyright notice:
# The code changes made to this file are the intellectual property of TheDarkWraith and may not be used, modified, or duplicated in whole,
# or in part, without the express written permission of TheDarkWraith. The code changes made to this file may not be used in any commercial
# application of any form without the express written permission of TheDarkWraith.


###################################################################################################
#
#	Ship weapons:
#

strategy ShipFire(Ship)
 {
	precond
	{
		Ship:ContactPresenceIs(PRESENCE_SENSORS, 0) or (Ship:ContactPresenceIs(PRESENCE_LOOSING, 0) and Ship:GetContactLostTime() <= 360.0)
	}
	strategies
	{
		DC,
		Cannons,
		CannonsAtSubmerged
		#CheckStarshellEnable,
		#ShipFireStarShells,
		#ShipFireStarShellsDistance
	}
}

strategy DC(Ship)
{
	precond
	{
		Ship:ContactIs(SUBMARINE) or (Ship:ContactIs(UNITUNKNOWN) and Ship:GetContactDepth() <= -4.0)		#SUBISSUBMERGEDDEPTH
	}
	strategies
	{
		DCRacks,
		HHogs,
		DCThrower
	}
}

strategy DCRacks(Ship)
{
	precond
	{
		Ship:CanFireDCRacks() and Ship:GetContactDepth() <= -4.0 and Ship:GetCurrentSpeed() >= 2		#SUBISSUBMERGEDDEPTH
	}
	action
	{
		Ship:FireDCRacks();
	}
}

strategy HHogs(Ship)
{
	precond
	{
		Ship:CanFireHHogs()
	}
	action
	{
		Ship:FireHHogs();
	}
}

strategy DCThrower(Ship)
{
	precond
	{
		Ship:CanFireDCThrowers()
	}
	action
	{
		Ship:FireDCThrowers();
	}
}

strategy Cannons(Ship)
{
	precond
	{
		Ship:CanFireCannons()
	}
	action
	{
		Ship:FireCannons();
	}
}

strategy CannonsAtSubmerged(Ship)
{
	precond
	{
		(Ship:ContactPresenceIs(PRESENCE_LOOKOUT, 0) or Ship:ContactPresenceIs(PRESENCE_SONAR, 0)) and (Ship:ContactIs(SUBMARINE) or Ship:ContactIs(UNITUNKNOWN)) and Ship:GetContactDepth() <= 0.0 and Ship:GetContactDepth() >= -20.0 and Ship:GetContactRelDist() <= 8000
	}
	action
	{
		Ship:FireCannons();
	}
}




#strategy CheckStarshellEnable(Ship)
#{
#	precond
#	{
#		(Ship:ContactPresenceIs(PRESENCE_SENSORS, 0) or Ship:ContactPresenceIs(PRESENCE_LOOSING, 0)) and Ship:GetContactRelDist() <= 10000
#	}
#	action
#	{
#		Ship:EnableStarshells();
#	}
#}



#
#strategy ShipFireStarShells(Ship)
#{
#	precond
#	{
#		Ship:CanFireStarShells() and Ship:GetContactRelDist() <= 10000
#	}
#	action
#	{
#		Ship:FireStarShells();
#	}
#}
#
#strategy ShipFireStarShellsDistance(Ship)
#{
#	precond
#	{
#		Ship:GetContactRelDist() <= 10000
#	}
#	action
#	{
#		Ship:FireStarShells();
#		#Ship:ShipWaitAction(10)
#		Ship:TimeEventHappen(5);
#	}
#}

Maybe i have wrong version or something?

[volodya61]

Originally Posted by gap

Yep, try Volodya's suggestion V13

Originally Posted by vdr1981

OK then... Here's entry from IRAI patch1, can you see something strange then?

If my IRAI 0.37 (its files) isn't damaged I'll send it to you later..

[vdr1981]

Originally Posted by volodya61

If my IRAI 0.37 (its files) isn't damaged I'll send it to you later..

Very well, tnx Volodya!

[vdr1981]

Small breakthrough...Unquoting linkname values from ships eqp file will remove starshells effects...

;SH5 FX Update
[Equipment 23]
NodeName=M90
LinkName=NULL;5InchStarShellGun;NULL
StartDate=19380101
EndDate=19451231

;SH5 FX Update
[Equipment 24]
NodeName=M91
LinkName=NULL;scc_9_gun;NULL
StartDate=19380101
EndDate=19451231

[volodya61]

Originally Posted by vdr1981

Very well, tnx Volodya!

Hi Vecko, do you still need my files?

[vdr1981]

Sure,why not!
I can remove starshells but i could use more elegant solution...

[volodya61]

Originally Posted by vdr1981

Sure,why not!
I can remove starshells but i could use more elegant solution...

I don't remember exactly, maybe I've changed something else there - http://rghost.ru/49339218

[vdr1981]

Originally Posted by volodya61

I don't remember exactly, maybe I've changed something else there - http://rghost.ru/49339218

Tnx Mate!