[REL] R.S.D. - Reworked Submarine Damage

[gap]

Originally Posted by vdr1981

I dont think so...Stormfly's complaining since v4...

It would be nice knowing since which version problems started for each one of our beta testers. Could you post download links of the RSD older versions, for them to quickly check it?

[plj]

Originally Posted by vdr1981

Ok guys, one quick test...

uninstall RSD and try problematic campaigns with this...http://www.mediafire.com/download/nf...v/RSD+test.rar

EDIT:
Plj,anyone?

No luck, CTD at point where dock starts to fade in, same as usual. It went to desktop even faster, without asking for orders in audio. Modlist, just removed 5.3 and inserted the test one, and started new campaign with unused captain name:

Generic Mod Enabler - v2.6.0.157
[D:\Games\Silent Hunter 5\MODS]

Accurate German Flags
sobers game loading tips V8 SH5
DBM Background Video
Grossdeutscher Rundfunk
U-Boat Watch Crew Routine SFX
Messervy_s_gramophone_pack1
SteelViking's Interior Mod V1.2
SteelViking's Interior Mod V1.2.2 Patch
Fuel Gauge WoGaDi_SteelViking's Interior
Fix clock rear torpedo room VIIA
Depth Charge Range Fix
Capthelms Audio+SV Touch Ups
sobers multi color mod V5
DynEnv v2.9 - 1. Main Mod
DynEnv v2.9 - No Underwater Impurity Patch
DynEnv v2.9 - 5.c Ambient Settings - Darker Nights-No Murky Waters
DynEnv v2.9 - 9. Sobers Best Ever Tweaks
DynEnv v2.9 - 12. Sounds
Small_trees_SH5_V1
sobers smoke screen V1 SH5 (DynEnv compatible)
sobers water splash anim SH5
sobers best ever fog  V22 SH5
sobers base sky mechanics V1
sobers better terrain v3 SH5
sobers waves mod V12 27032013
sobers more trees SH5
Window Lights Redone V1
New Torpedo Door Sound Mix
Pascal-sh5-Crew-Uniforms 06.2012
SH5_7A_Conning_Fix
SteelViking's Bunker Fixes V1.0
German U-Boat Hydrophone SFX
Equipment_Upgrades_Fix_v1_4_byTheBeast
Equipment_Upgrades_Fix_v1_4_Patch_1
Equipment_Upgrades_Fix_v1_4_Patch_1_HotFix
Equipment_Upgrades_Fix_v1_4_Patch_1 (available by date) V9 by sober
EUF_UBoat_FX_v0_0_3_ byTheBeast
SH5 Longer Repairs v.1
FX_Update_0_0_22_ByTheDarkWraith
FX_Update_0_0_22_Torpedoes (modified for torpedoes failure patches)
FX Update 0.0.22 Torpedoes - MagDet range 3m (modified for torpedoes failure patches)
AI_sub_crew_1_0_2_TheDarkWraith
NewUIs_TDC_7_5_0_ByTheDarkWraith
NewUIs_TDC_7_5_0_alt_officer_wounded_by_Torpedo
NewUIs_TDC_7_5_0_Real_Navigation
NewUIs_TDC_7_5_0_jimimadrids_map_tools
NewUIs_TDC_7_5_0_RadCapTools_0_2_alpha
Sjizzles - Charts for NewUIs part1_07.06.2013
Sjizzles - Charts for NewUIs part 2_07.06.2013
Sjizzles - Charts for NewUIs part 3_24.06.2013
Sjizzles - Charts for NewUIs part 4_20.07.2013
Manos Scopes-patch for 16x9
Submarine's .sim&cfg (modified for engine ratio + independent control patches)
gap - armaments & equipments patch v 0.2
IRAI_0_0_39_ByTheDarkWraith
IRAI_0_0_39_ByTheDarkWraith_Patch_1
R.E.M_by_Xrundel_TheBeast_1.2
R.E.M_by_Xrundel_TheBeast_1.2 - no hyd on surface - NewUIs-IRAI compatible
silentmichal's interior mod 1.2.3
Church's Compass Dials Mod v2.2 - Option One
Cerberus62 Corrected Depth Charge Projector 1.0
Flower_Class_Corvette_Pack
Soldati Fix
NOZAURIO'S SKIN (Standar No Emblem) v-1.1.0
Expanded Navies by Cybermat47 v.1.0.01
smaller flags for Warships 1_0b
OPEN HORIZONS II_full v2.2
OPEN HORIZONS II v2.2 - ORP Gryf and HMS Rocket no reflection patch
Sobers Terrain fix for OH2 V2.2
Open Horizons II - Hospital Ship Texture Fix v 1
OH II Minefield map for TDWs Ui
RPM Hydrophone v2.2.1
SH5Lifeboats by Rongel TDW stoianm v2.1
SH5Lifeboat Wooden ver. 0.2
SkyBaron's Bold SFX for SH5 1.0
SkyBaron's Leigh Light for SH5 1.1
Reworked Morale and Abilities v.1.1
MightyFine Crew Mod 1.2.1 Alt w beards
MFCMCCDLite
Speech fixes and additions (english version)
sobers green crew training V4 SH5
TDW FX Fix for Sobers chimney smoke
sobers Lights Cfg V5 SH5
Trevally Tutorial - All v0.2(for OHIIv1.3)
Krauters Automated Scripts (v5_0_0 compatible)
Trevally Automated Scripts v0.6
Trevally Harbour & Kiel Canal Pilot v3.1
Trevally TDC Help v2
MadMaxs_SH5_Subdiesel (mono) v2
gap - Sonar Sound Collection v 1.0 for SH5 - Distorted
sobers no footstep sound mod
sobers Realistic contrast V6 SH5
EQuaTool 01.01 by AvM - Large Style
AOB slide ruller for TDW UIs and MO by stoianm
gap - HD 1 deg Scope Bearing v 1.0
sobers deck crew always whispering v2 SH5
sobers hud sounds V1 SH5
Reworked U-boat Guns (incomplete version)
sobers Depth of Field (DOF) V6 SH5
sobers map colors SH5 V1
Shadow Improvement ModLR
SH5 External Cargo 1.0
TDW_GenericPatcher_v_1_0_149_0
RSD test

Originally Posted by gap

I think I have spotted an error on my part. I strongly hope that this is the culprit of your problems. I will post more on it later.

P.S. @ Mike, plj and Stormfly:

can you guys confirm that v 5.1 of RSD, or previous, worked fine?

Sure thing .. if I can find 5.1

[plj]

This one ?

[gap]

Originally Posted by plj

Sure thing .. if I can find 5.1

Originally Posted by plj

This one ?

No, I think that R.S.D v 5.1 + R.S.D v 5.1 - destroyable GHG patch = R.S.D v 5.2, but better waiting for confirmation by Vecko

[plj]

I was just wondering ... are Magui users experiencing this issue ? If we can pin it down to something related to NewUI, we at least now which conflicts to look at ... or we can work out the difference .. or whatever you guys with an understanding of the problem feel needs to be worked on :p

[gap]

Originally Posted by gap

I think I have spotted an error on my part. I strongly hope that this is the culprit of your problems. I will post more on it later,

I had been looking into EUF files which get overwritten by other mods in sobers mega mod, though not being based on the former:

UBoot_Sensors.GR2 is altered by NewUIs and FX Update
UBoot_Sensors.sim is altered by NewUIs, FX Update, IRAI, and R.E.M. (TDW compatible)
NSS_Uboat7*.sns files are altered by NewUIs and RSD from v 5.2 on

EUF's NSS_Uboat7*.sns contain entries which are absent from their NewUIs counterparts (even though they have a more recent date). I still don't know if playable units' sns files really matter in the game architecture, and seeing that they are already ovewritten by NewUIs, I doubt at this point that they can be the culprit of your CTD problem, but I will nonetheless edit the ones of RSD for compatibility with EUF and post them here.

As for UBoot_Sensors GR2 and sim files, I still need to spot the changes made on them respectively by TDW and TheBeast

[gap]

Originally Posted by plj

Yeah, I just removed the stupid hashtag :p

Originally Posted by plj

I'll have no idea how to check that tbh. I'll have a look and see if I can figure it out :p

That is easy, using Winmerge. You should compare the upc file found in sober's "patch_1 available by date" with its counterpart in EUF's "patch_1_hotfix", and look for changed settings/missing entries (Winmerge does it automatically). Ideally, only UnitUpgradePackIntervalOptions entries should change between the two files.

Originally Posted by plj

running it now .. cant find a few things .. will try to reproduce a report or something ..

Originally Posted by volodya61

It's not a JSGMEModValidator report as Gap mentioned.. it's SHValidator report.. a bit different things..

Your first long doesn't give me any useful information. I have already started digging in the second log for possible clues

Originally Posted by vdr1981

1. Yes, always...

Okay, so the problem is not the U-boat striking the bottom

Originally Posted by vdr1981

2. You see my modlist above (#343)? If that is correct order than answer is yes...Note that most of the EUF files are overwriten by OHII...

Never realized those conflicts guys
I will investigate them: the answer to your problems may come from there

Originally Posted by vdr1981

P.S. Gap, do you have installed SH5 at all?

yes, I do, but my system is getting old, I got GPU overheating problems (I only have a laptop), and I rarely run the game these days. Normally I try figuring out things by looking directly at files, and I launch the game if I really need to.

Originally Posted by Mikemike47

In case of you missed my posts somewhere on this thread. I never played version 5.2. I always have CTDs with silentotto and/or Mare Nostrum, Battle of Medittteranean using v5.3. Both campaigns. Same campaigns and silent otto worked fine with Nautical....Torpedo and version 4. I do not have download corruption either for v5.3 since I tested that.

Okay, so the problem presented itself after v 4

Originally Posted by Mikemike47

Is dates in the upcge files?

Euipment upgrades availability dates are stored in UpgradePacks.upc. Default EUF settings make all the upgrades available from beginning (for allowing players to test all the upgrades at once), but sober's EUF_Patch_1 (available by date) restores historical (more or less) availability dates.

Originally Posted by vdr1981

So Plj can't start mare nostrum, Mike cant start both Med. campaigns and Stormfly cant start nothing?

Originally Posted by vdr1981

Ok guys, one quick test...

uninstall RSD and try problematic campaigns with this...http://www.mediafire.com/download/nf...v/RSD+test.rar

What is that?

[gap]

Originally Posted by vdr1981

You see my modlist above (#343)? If that is correct order than answer is yes...Note that most of the EUF files are overwriten by OHII...

Originally Posted by gap

Never realized those conflicts guys
I will investigate them: the answer to your problems may come from there

Reported in OH's thread. wainting for an answer by Trevally

[vdr1981]

Ignore v5.1... I uploaded wrong files. That's why i left it from changelog completely .

Originally Posted by plj

No luck, CTD at point where dock starts to fade in, same as usual. It went to desktop even faster, without asking for orders in audio. Modlist, just removed 5.3 and inserted the test one, and started new campaign with unused captain name:

Cpy...I'm trying to exclude some files from RSD. Hopefully , this will give us idea what's causing your CTD...I'll give you another archive this day afternoon.(I'm not at home right now).

Originally Posted by gap

Okay, so the problem presented itself after v 4

Negative Gap! Like i said, Stormfly had mare nostrum problems even with v4...
I'll upload all versions later...

In sober's list, recommended RSD version seems to be v4. Would using v5.3 cause problems ?

[plj]

Originally Posted by vdr1981

Negative Gap! Like i said, Stormfly had mare nostrum problems even with v4...
I'll upload all versions later...

CTD on all campaigns can not be related if logic is applied, even tho that is not adviced :p Mike and I can reliably reproduce the Battle for the Mediteranean CTD .. I'd love to test if I can reproduce the CTD on everything bug too, but untill it's reproduced, it should be treated as non-related, and when it's reproduced, modlists will have to be compared to see of other conflicts can be causing it.

I'm not entirely sure R.S.D. is de culprit here .. it may be like gap suggests that it only helps reveal another issue that has been lingering in the code. If mike and me can get stuff to work with v4, we know that the changes between those versions trigger the issue, which would help narrow stuff down.

[gap]

Originally Posted by plj

I'm not entirely sure R.S.D. is de culprit here .. it may be like gap suggests that it only helps reveal another issue that has been lingering in the code. If mike and me can get stuff to work with v4, we know that the changes between those versions trigger the issue, which would help narrow stuff down.

upc/upcge are relatively complex files, with lot of settings, and cross references among them and with other files. Overwrite any of them or their linked files without updating their references accordingly, and you will likely break something. The worst part is that the induced errors won't probably reveal themselves from the beginning, but when a given boat or equipment whose settings were screwed up, will become available in campaign.

[vdr1981]

Originally Posted by makiferol

In sober's list, recommended RSD version seems to be v4. Would using v5.3 cause problems ?

You tell us... Try it with mare nostrum/Mediteran campaign and post here again...OK?

[plj]

Someone have a link to RSD 4 ?

[gap]

Originally Posted by plj

Someone have a link to RSD 4 ?

Read below

Originally Posted by vdr1981

I'll upload all versions later...

On a side note: have you guys read this?

Originally Posted by Trevally.

If CTD are happening with MareNostrum (first time a type c is issued) and a direct date change from OHII - the Western Approaches should also CTD??

If you check post 2 in this thread you will see all the campaign where a type c is issued. If they do not CTD and the MN and WA do then it would look like date related.

If MN CTD and WA does not - this it is not date related.

We need to know what campaigns CTD on silentotto and which do not (full list)

For each beta tester we need the following chart to be filled in:

				no R.S.D.	R.S.D. v1	R.S.D. v2	R.S.D. v3	R.S.D. v4	R.S.D. v5	R.S.D. v5.2	R.S.D. v5.3	
Coastal Waters

Happy Times

Mare Nostrum

Western Approaches

Battle of the Mediterranean

Operation Drumbeat

Arctic Convoys

Distant Waters

The Black Pit

Monsun Gruppe

Turning Point

The Final Years

I realize that they are (8 x 12 =) 96 campaign loadings in total, so take your time on it! Use your respective mod lists for the suggested tests, with no other change than the enabling (at the end of the JSGME list) of the different R.S.D. versions. Personally I would start with our "blank" (your full mod lists with no R.S.D. enabled), followed by R.S.D. v4 testing (the version that for many of you seem to procede the "rupture point") and v5 testing

In the meanwhile I am working on an EUF/NewUIs/IRAI/FxU/OHII/RSD compatibility patch which Vecko should use for migrating his RSD settings on it