[REL]Bad weather fix for SH3

[avee]

Originally Posted by h.sie

65 downloads in 2 days. I would be glad to see more test reports.

Report here.

I was always bugged by SH3 weather because it doesnt change for a long time after loading game. That`s why i like your work direction.

I began a career with your mod and it worked great, until today i loaded yesterdays patrol and decided to measure how much time it takes for weather to change. I was checking weather every hour while being at x256 or x512 time compression. It seems my weather is stuck at "No clouds, no rain, excellent visibility, wind 0 kts".
Here is the log:

[Log Entry 472]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=1800
Categ=1

[Log Entry 473]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=1859
Categ=1

[Log Entry 474]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=2000
Categ=1

[Log Entry 475]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=2100
Categ=1

[Log Entry 478]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=2200
Categ=1

[Log Entry 479]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390906
Time=2300
Categ=1

[Log Entry 480]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=0
Categ=1

[Log Entry 481]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=101
Categ=1

[Log Entry 482]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=200
Categ=1

[Log Entry 483]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=300
Categ=1

[Log Entry 485]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=400
Categ=1

[Log Entry 486]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=501
Categ=1

[Log Entry 487]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=559
Categ=1

[Log Entry 488]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=700
Categ=1

[Log Entry 489]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=800
Categ=1

[Log Entry 490]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=900
Categ=1

[Log Entry 491]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1000
Categ=1

[Log Entry 492]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1059
Categ=1

[Log Entry 493]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1200
Categ=1

[Log Entry 495]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1300
Categ=1

[Log Entry 497]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1400
Categ=1

[Log Entry 499]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1500
Categ=1

[Log Entry 501]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1601
Categ=1

[Log Entry 502]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1700
Categ=1

[Log Entry 504]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1758
Categ=1

[Log Entry 506]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=1900
Categ=1

[Log Entry 507]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=2000
Categ=1

[Log Entry 509]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=2100
Categ=1

[Log Entry 510]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=2200
Categ=1

[Log Entry 511]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390907
Time=2301
Categ=1

[Log Entry 513]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390908
Time=0
Categ=1

[Log Entry 514]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390908
Time=100
Categ=1

[Log Entry 516]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390908
Time=201
Categ=1

[Log Entry 518]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 162.
Date=19390908
Time=313
Categ=1

[Log Entry 519]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 154.
Date=19390908
Time=359
Categ=1

[Log Entry 520]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=500
Categ=1

[Log Entry 521]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=600
Categ=1

[Log Entry 523]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=700
Categ=1

[Log Entry 524]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=801
Categ=1

[Log Entry 525]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=900
Categ=1

[Log Entry 526]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1001
Categ=1

[Log Entry 527]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1100
Categ=1

[Log Entry 531]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1200
Categ=1

[Log Entry 533]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1300
Categ=1

[Log Entry 534]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1400
Categ=1

[Log Entry 535]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1501
Categ=1

[Log Entry 538]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1600
Categ=1

[Log Entry 539]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1700
Categ=1

[Log Entry 541]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1804
Categ=1

[Log Entry 543]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=1901
Categ=1

[Log Entry 544]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=2000
Categ=1

[Log Entry 545]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=2101
Categ=1

[Log Entry 547]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=2159
Categ=1

[Log Entry 548]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390908
Time=2300
Categ=1

[Log Entry 549]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1
Categ=1

[Log Entry 551]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=102
Categ=1

[Log Entry 553]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=256
Categ=1

[Log Entry 554]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=408
Categ=1

[Log Entry 556]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=519
Categ=1

[Log Entry 557]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=610
Categ=1

[Log Entry 559]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=715
Categ=1

[Log Entry 560]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=800
Categ=1

[Log Entry 561]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=900
Categ=1

[Log Entry 562]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1006
Categ=1

[Log Entry 563]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1058
Categ=1

[Log Entry 564]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1200
Categ=1

[Log Entry 567]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1251
Categ=1

[Log Entry 568]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1401
Categ=1

[Log Entry 570]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1502
Categ=1

[Log Entry 571]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 124.
Date=19390909
Time=1545
Categ=1

[Log Entry 572]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 167.
Date=19390909
Time=1659
Categ=1

[Log Entry 573]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 204.
Date=19390909
Time=1800
Categ=1

[Log Entry 574]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 240.
Date=19390909
Time=1900
Categ=1

[Log Entry 575]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 277.
Date=19390909
Time=2001
Categ=1

[Log Entry 576]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390909
Time=2101
Categ=1

[Log Entry 577]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390909
Time=2201
Categ=1

[Log Entry 578]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390909
Time=2300
Categ=1

[Log Entry 579]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=3
Categ=1

[Log Entry 580]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=59
Categ=1

[Log Entry 581]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=202
Categ=1

[Log Entry 582]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=259
Categ=1

[Log Entry 583]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=401
Categ=1

[Log Entry 584]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=500
Categ=1

[Log Entry 585]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=601
Categ=1

[Log Entry 587]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=703
Categ=1

[Log Entry 588]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=800
Categ=1

[Log Entry 589]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=901
Categ=1

[Log Entry 590]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1000
Categ=1

[Log Entry 591]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1059
Categ=1

[Log Entry 592]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1200
Categ=1

[Log Entry 593]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1300
Categ=1


[Log Entry 595]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1401
Categ=1

[Log Entry 596]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1500
Categ=1


[Log Entry 598]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1556
Categ=1


[Log Entry 600]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1701
Categ=1

[Log Entry 602]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1800
Categ=1

[Log Entry 603]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=1901
Categ=1

[Log Entry 604]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=2001
Categ=1

[Log Entry 605]
Type=0
EntryText=No clouds, no rain, excellent visibility, Wind speed 0 m/s, direction 296.
Date=19390910
Time=2100
Categ=1

Patrol was loaded at about 16:40 (game time) september 6 1939. First weather change (wind direction only!) happened around 03:59 september 8. Wind direction changed several times and freezed again for a long time. There were several such wind direction changes but no other changes at all!

Maybe, the problem is with my sh3.exe file - it is "old" .exe file with starforce manually removed, but your mod is supposed to work with all .exe. And "Weather Transitions Test Fix V2" works fine...

Maybe that "magic" weather of 0 fog, 0 cloud, 0 wind may cause such problems? Or is such weather already a symptom of some serious weather system problems on my rig?

Thanks for your help!

[Stiebler]

@H.sie,

I have only just noticed your post #149 asking for my input, sorry about that.

I prefer your bad weather fix (changing clouds and fog) to my own (changing windspeeds), so probably it will be less confusing for everyone if you give only the link to your own bad weather fix in the first post of this thread.

Two more proper war patrols completed here, each of two months in late 1944, with NYGM and with your bad weather fix installed (also with your V15D beta 4 mod installed, with repairs disabled) - no problems at all. The weather patterns look very good.

Yes, I would like to see your commented assembly code, please, for instructional purposes. Thanks very much for the offer.

Stiebler.

[Reece]

@ avee, Your log only shows weather for part of a day only!! this mod is to fix the old bug of weather being stuck for weeks (mostly with poor fog/visibility), your results seem fine to me, see how it goes over a whole patrol.

[h.sie]

@Reece: His logs show 3-4 days. scroll down the list box.

@avee: I also had such a behaviour during testing in very high time-compression (1024) and in a single-mission. but since I was not able to reproduce this, I didn't pay much attention to it. After reloading all worked well. So I still don't know if that is related to my fix or not.

Any others have this behaviour??

[avee]

Originally Posted by h.sie

@avee: I also had such a behaviour during testing in very high time-compression (1024) and in a single-mission. but since I was not able to reproduce this, I didn't pay much attention to it. After reloading all worked well. So I still don't know if that is related to my fix or not.

I repeated test run from the same save 2 more times.

First time first weather change happened 36 hours after loading and changed wind direction and clouds (light). Several days later visibility became moderate. Several more days later wind speed changed to 1 m/s and clouds to heavy.

Second time first weather change again happened around 36 hours after loading and changed wind direction and visibility (moderate).

It seems that either i am very unlucky or this part works wrong:

This fix also fixes a bug, that the weather time counter is not saved in a savegame,
so that the counter always starts at 0 every time you load a mission or savegame.
That means, that the first weather change always occurs exactly after a full
weather period (20 - 40 hours).

Now, the time counter is initialized with a randomly chosen value between 0 and 95% of the
weather period, so that a weather change shortly after loading a mission is possible.

[h.sie]

Start value for time counter is randomly chosen (and this worked well in my tests), so I think that 2 trials are not enough to get a reliable result. Additionally, at the start of a new weather period sometimes weather does not change. So, Please, give it a chance and some more tests. If it does not work, I'll look into it.

Thank you for helping!

[ryanwigginton]

Providing h.sie doesn't mind, can we have this thread along with h.sie's realistic repair thread stickied please? Both are SH3 essentials.

[Hitman]

can we have this thread along with h.sie's realistic repair thread stickied please? Both are SH3 essentials.

Good idea, I'll take a look into that later as I would probably need to clear a bit the stickies before, or risk cluttering too much the main page

[h.sie]

I think there is currently no need to make them sticky ATM:

1) Too less downloads. So these mods are essential - for a minority.

2) They seem to be sticky already by high activity.

3) Not 100% clear that Bad Weather Fix works. See posts from user avee.

[SquareSteelBar]

Originally Posted by h.sie

...Too less downloads. So these mods are essential - for a minority...

Not only these mods are essential, even that minority is essential since it consists of Hardcore Kaleuns...

[h.sie]

avee is right!

under certain conditions, during game load, the weather time counter is still initialized with 0 instead of a random number. I already found the reason, so expect a new version in the next time.

no worry, the current weather fix V1 beta works, but the first weather change always occurs after 20-40 hours, and not randomly, as I promised. this will be fixed soon.

THANK YOU AVEE!

[ridley]

Would it be possible to have a version of your mod that changed the weather at a fixed, not random interval.

I mainly play multiplayer and would love to have the weather change during the game for obvious reasons this would have to be the shorts time possible, 1/2 hour? It would have to be non random in some wy to avoid sync problems with other players, wouldnt it?

Ridley

[h.sie]

@ridley: oops, I never thought about multi-players, since I never played this. My patch won't work for multiplayers, because weather changes are randomly generated and so maybe weather could change to good for one player and to bad for the second. I don't know if there is a sync-mechanism included.

I even cannot test it, since I have only one PC (XP and Win7 in dual boot).

Sorry to say, but for multiplayers I recommend to use stock SH3 waether.

[ridley]

If there was a way to remove the randomisation and set the interval to say 1/2 hour I would love to give it a try in multiplayer. There is a sync option BTW.

Ridley

[h.sie]

Regarding Multiplayer: It is very much possible that the random seed is synchronized for all multiplayers - that means, that the generated random numbers (and thus the weather changes and intervals) are the same for all connected players. it is worth testing.

you want 30 minutes weather changes??? common are 20-40 hours