[REL]Bad weather fix for SH3

Stiebler · 12-01-10, 05:24 AM

H.sie has now checked my code for the weather fix on his XP/32-bit installation. (I have tested it with Win-7/64-bit, so it should work with Vista too, 32- and 64- bit). It appears to be stable on both our installations.

Therefore, anyone who wishes to try out for themselves this first weather fix should download the link here:
http://www.subsim.com/mods1/nygm/Stiebler_EnvSim.7z

(Unzip the file first, then install with JSGME).

This should be regarded as a 'proof of concept', not the finished code.
H.sie is working on a solution which will limit (with two counters) the extent of windspeed and fog, and I believe that this solution will probably be superior. Or maybe both solutions should be combined.

H.sie has also pointed out that my solution allows higher wind-speeds (up to 15 m/s) in sheltered waters, such as at Koenigsberg, where the devs tried to force low wind-speeds only (6 m/s). But that is not important for a 'proof of concept'.

*WE WANT FEEDBACK*
Is the code stable on everyone's computer? (as well as on mine and H.sie's). We are pretty certain that it is, but it helps to check with the wider user base.
Does it perform as expected? (Has it stopped persistent foggy-storms?) In checking this item, remember that my code relies on a drop in windspeed causing a slower removal of heavy rain and heavy fog. If the windspeed drops for one weather change, then returns to 15 m/s (as may occur randomly), then you will probably continue to see persistent heavy rain and fog. But I have seen no foggy-storms persist for longer than five days, and only twice for five days.

*HOW TO TEST*
Try these areas:
a) North Atlantic, general war patrol.
b) Cruising around the equator, where weather changes occur very frequently (so much higher chances of foggy storms).
c) In the Arctic, where slow weather changes and the nature of the weather intended by the devs means that you are likely to discover that the winds stick for long periods at 7 m/s.

Higher tc (time compression) results in a trend towards worse weather. So try testing at as high a tc as practical. However, if the tests are to have any real value, we also need some testers to play as though for a normal patrol, wherever they choose to go, and for any tc that they wish.

CREDIT TO H.SIE.
I have been only the technician to create this code. It was H.sie who identified the key section of code that needed fixing, and also was the first to discover the original bug in the windspeed code by the devs. It was H.sie who introduced me to the Ollydbug2 disassembler that I used to create this code, and it was H.sie who explained patiently by PM how best to use the disassembler (its documentation is lamentably poor.)

Stiebler.

12-01-10, 05:24 AM	#16
Stiebler Fuel Supplier Join Date: Oct 2005 Location: London, UK Posts: 1,237 Downloads: 29 Uploads: 4	Try a weather fix H.sie has now checked my code for the weather fix on his XP/32-bit installation. (I have tested it with Win-7/64-bit, so it should work with Vista too, 32- and 64- bit). It appears to be stable on both our installations. Therefore, anyone who wishes to try out for themselves this first weather fix should download the link here: http://www.subsim.com/mods1/nygm/Stiebler_EnvSim.7z (Unzip the file first, then install with JSGME). This should be regarded as a 'proof of concept', not the finished code. H.sie is working on a solution which will limit (with two counters) the extent of windspeed and fog, and I believe that this solution will probably be superior. Or maybe both solutions should be combined. H.sie has also pointed out that my solution allows higher wind-speeds (up to 15 m/s) in sheltered waters, such as at Koenigsberg, where the devs tried to force low wind-speeds only (6 m/s). But that is not important for a 'proof of concept'. WE WANT FEEDBACK Is the code stable on everyone's computer? (as well as on mine and H.sie's). We are pretty certain that it is, but it helps to check with the wider user base. Does it perform as expected? (Has it stopped persistent foggy-storms?) In checking this item, remember that my code relies on a drop in windspeed causing a slower removal of heavy rain and heavy fog. If the windspeed drops for one weather change, then returns to 15 m/s (as may occur randomly), then you will probably continue to see persistent heavy rain and fog. But I have seen no foggy-storms persist for longer than five days, and only twice for five days. HOW TO TEST Try these areas: a) North Atlantic, general war patrol. b) Cruising around the equator, where weather changes occur very frequently (so much higher chances of foggy storms). c) In the Arctic, where slow weather changes and the nature of the weather intended by the devs means that you are likely to discover that the winds stick for long periods at 7 m/s. Higher tc (time compression) results in a trend towards worse weather. So try testing at as high a tc as practical. However, if the tests are to have any real value, we also need some testers to play as though for a normal patrol, wherever they choose to go, and for any tc that they wish. CREDIT TO H.SIE. I have been only the technician to create this code. It was H.sie who identified the key section of code that needed fixing, and also was the first to discover the original bug in the windspeed code by the devs. It was H.sie who introduced me to the Ollydbug2 disassembler that I used to create this code, and it was H.sie who explained patiently by PM how best to use the disassembler (its documentation is lamentably poor.) Stiebler. __________________ NYGM Tonnage War Mod - More than a mod: it's an experience!