[REL] Multiple UIs for SH5 with TDC

[tscharlii]

Originally Posted by plj

I can confirm the bugreport as a valid one. TDW used true bearing where he should have used relative bearing.

Good thing you asked in the other thread, how confident I am with the fix proposal. I looked at it again, and I think the code that selects the hydrophone contact to follow deserves even more reviewing.

TDWs original Code in HydrophoneFollowNearestContact(): (/data/Scripts/Stations/Hydrophone.py)

        for contact in contacts:
            if sub.HeadingDEGToContact( contact ) >= ( hydroangle - sweeprange ) and sub.HeadingDEGToContact( contact ) <= ( hydroangle + sweeprange ) and sub.RangeToContact( contact ) <= maxrange:
                if hydrocontact == None:
                    hydrocontact = contact
                else:
                    if sub.HeadingDEGToContact( contact ) <= sub.HeadingDEGToContact( hydrocontact ) and sub.RangeToContact( contact ) < sub.RangeToContact( hydrocontact ):
                        hydrocontact = contact

In my opinion it should read (Be careful, if you copy paste from here, the indentation has to be done using tabs, not spaces. Python is quite picky about this. Better download the mod below):

        for contact in contacts:
            if TDWUtils.GetContactHeading( sub.HeadingDEGToContact( contact ) - sub.HeadingDEG ) >= ( hydroangle - sweeprange ) and TDWUtils.GetContactHeading( sub.HeadingDEGToContact( contact ) - sub.HeadingDEG ) <= ( hydroangle + sweeprange ) and sub.RangeToContact( contact ) <= maxrange:
                if hydrocontact == None:
                    hydrocontact = contact
                else:
                    if sub.RangeToContact( contact ) < sub.RangeToContact( hydrocontact ):
                        hydrocontact = contact

The semantics of this is: Follow the nearest contact within maxrange on hydrophone needle bearing plus-minus sweeprange

The change in the second line ensures the code deals with bearings relative to the sub's course instead of true, north-aligned bearings.
The change in the sixth line ommits a bogus if-condition. Why only select the nearest contact, if it also happens to be at a lesser bearing than other contacts in that area, and otherwise follow a contact further away. The command is called "Hydrophone follow nearest contact", after all.

This fix is available as a mod, activate it via JSGME after TDWs NewUIs:
http://www.deguero.de/jel/Hydrophone..._0_To_7_5_0.7z

[plj]

Much appreciated, will test and report back!

[V13dweller]

Originally Posted by gap

My data lines have been on the fritz due to what I think are site-works going on near by, but Western Australia is renowned for poor internet.

I was able to get a working version tonight though, thankfully.

I blame poor maintenance, I have heard reports of rotted wiring being changed in my area recently, so that could be the cause.

[gap]

Originally Posted by V13dweller

My data lines have been on the fritz due to what I think are site-works going on near by, but Western Australia is renowned for poor internet.

I was able to get a working version tonight though, thankfully.

I blame poor maintenance, I have heard reports of rotted wiring being changed in my area recently, so that could be the cause.

Okay, what matters is that you have got back a working installation of the game

[porabotitel]

Is there a Russification of this mod?

[volodya61]

Originally Posted by porabotitel

Is there a Russification of this mod?

Welcome aboard

You can find it inside the mod.. folder Text..

[xSmithyx]

Hi there,

Having an issue with the game/mod at the moment. Every time I go to load a save game or load a new game I get the following error:

Error PythonImportErrorException:
Cannot import name Game_NewPlayerLogMessageCSharp in Data/Scripts/Menu/TheDarkWraithUserOptions.py

Traceback:
File ScriptManagerWrapper , line unknown, in CheckForStartGame
File , line 0 , in <string> ##2181
File , line 0, in StartGame

Script disabled!

I have tried everything from reinstalling the game to the mods. I have ran the SHValidator tool too many times to count. Any advice would be MUCHO appreciated.

[THE_MASK]

Originally Posted by xSmithyx

Hi there,

Having an issue with the game/mod at the moment. Every time I go to load a save game or load a new game I get the following error:

Error PythonImportErrorException:
Cannot import name Game_NewPlayerLogMessageCSharp in Data/Scripts/Menu/TheDarkWraithUserOptions.py

Traceback:
File ScriptManagerWrapper , line unknown, in CheckForStartGame
File , line 0 , in <string> ##2181
File , line 0, in StartGame

Script disabled!

I have tried everything from reinstalling the game to the mods. I have ran the SHValidator tool too many times to count. Any advice would be MUCHO appreciated.

I had that as well . Reinstalling the game was the only thing that fixed it .

[plj]

Originally Posted by xSmithyx

Hi there,

Having an issue with the game/mod at the moment. Every time I go to load a save game or load a new game I get the following error:

Error PythonImportErrorException:
Cannot import name Game_NewPlayerLogMessageCSharp in Data/Scripts/Menu/TheDarkWraithUserOptions.py

Traceback:
File ScriptManagerWrapper , line unknown, in CheckForStartGame
File , line 0 , in <string> ##2181
File , line 0, in StartGame

Script disabled!

I have tried everything from reinstalling the game to the mods. I have ran the SHValidator tool too many times to count. Any advice would be MUCHO appreciated.

Try re-downloading NewUI's and using a fresh copy ... maybe it's corrupted.

[Oleander]

I'm getting that same error now, a new reinstall of SH5 didn't fix it.

[Oleander]

I went back and deleted everything, including stuff in My Documents, and then reinstalled and that seems to have worked. Any ideas on what causes the python error?

[Mikemike47]

Originally Posted by Oleander

I went back and deleted everything, including stuff in My Documents, and then reinstalled and that seems to have worked. Any ideas on what causes the python error?

Yes, JSGME leftovers. Click on my signature link Post #6, 8 talk about python errors. Post #3 has common JSGME problems and solutions.

[Rongel]

Quick question!

Do people still get the "unit destroyed" radio messages from sunk ships and destroyed planes? For some reason I haven't seen them in my megamod testing... I have activated this feature from options editor, but still nothing. I'm using TDW's NewUI version 7.4.2.

Really need them back!

[vdr1981]

Originally Posted by Rongel

Quick question!

Do people still get the "unit destroyed" radio messages from sunk ships and destroyed planes? For some reason I haven't seen them in my megamod testing... I have activated this feature from options editor, but still nothing. I'm using TDW's NewUI version 7.4.2.

Really need them back!

Did you try to set radioman intercept chance to 100% via options file editor? If your radioman can't intercept message even than, than something is wrong...

Just to confirm, electric engines on surface option is only available with v7.5.0, right ?

[Rongel]

Originally Posted by vdr1981

Did you try to set radioman intercept chance to 100% via options file editor? If your radioman can't intercept message even than, than something is wrong...

Just to confirm, electric engines on surface option is only available with v7.5.0, right ?

Yes, I have the radioman intercepting messages at 100% but still nothing... Electric engines on surface is probably only in v.7.5. but still have it in the patcher, haven't activated it though. So is everything working for you?