Crash: comments at the start of ini files considered harmful.

a.g. · 11-14-15, 03:27 AM

If I understand the disassembly correctly, only actual comments located before the first [...] should matter, whitespace is fine.

As an uninitialized variable bug, this belongs to a category that is notoriously difficult to reproduce intentionally: there are so many things that can affect what was stored in that memory location previously, from the list of mods, to details of implementation of malloc in system libraries. On my computer without the patch I just need to open Museum and click on New Zealand -> ASW Trawler, and it crashes in msvcrt71.dll with a null pointer access.

Apart from being able to reproduce the remote effects, there is the fact that that particular function in FileManager.dll has a code path where it doesn't initialize a memory location, but still reads it later - that is a definite bug

I also made a patch kit for applying or removing the patch more conveniently:

https://www.dropbox.com/s/jwjgutc0cs...Crash.zip?dl=1

11-14-15, 03:27 AM	#6
a.g. Swabbie Join Date: Nov 2015 Posts: 11 Downloads: 18 Uploads: 0	If I understand the disassembly correctly, only actual comments located before the first [...] should matter, whitespace is fine. As an uninitialized variable bug, this belongs to a category that is notoriously difficult to reproduce intentionally: there are so many things that can affect what was stored in that memory location previously, from the list of mods, to details of implementation of malloc in system libraries. On my computer without the patch I just need to open Museum and click on New Zealand -> ASW Trawler, and it crashes in msvcrt71.dll with a null pointer access. Apart from being able to reproduce the remote effects, there is the fact that that particular function in FileManager.dll has a code path where it doesn't initialize a memory location, but still reads it later - that is a definite bug I also made a patch kit for applying or removing the patch more conveniently: https://www.dropbox.com/s/jwjgutc0cs...Crash.zip?dl=1