SUBSIM Radio Room Forums



SUBSIM: The Web's #1 resource for all submarine & naval simulations since 1997

Go Back   SUBSIM Radio Room Forums > Silent Hunter 3 - 4 - 5 > SH5 Mods Workshop
Forget password? Reset here

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
Old 05-04-10, 04:02 PM   #3
reaper7
sim2reality
 
Join Date: Jun 2007
Location: AM 82
Posts: 2,280
Downloads: 258
Uploads: 30
Default

Quote:
Originally Posted by TheDarkWraith View Post
there are multiple things wrong with this code. First, your animation timer will never be reset because you told it not to:

The problem with writing the same code over and over instead of practicing code reuse is if you change one then you have to ensure you change them ALL. By localizing it all in one place you never have to worry about that ever happening

Thanks TheDarkWraith for your quick reply. Wastn't sure about the != part above as I copied that from the stock default Hud script had noticed you had == in your attack periscope script.

Yes, the fuction call is good practice - I had it called that way originally but when it didn't work. I did the Frankeinstein on it had chopped and pasted everywhere just to test the Night Time part of the code. Bad Practice

Thanks will give it another crack. And congrats with your new V2.1.0 its the biz.
reaper7 is offline   Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 10:15 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright © 1995- 2025 Subsim®
"Subsim" is a registered trademark, all rights reserved.