[REL] sh4speech - voice command for SH4

[minsc_tdp]

Originally Posted by ferg

OK, well, this "damage control team" problem is a strange one. It turns out it has nothing to do with the CSV files. I thought the problem wasn't appearing in stock until I remembered that I had left the stock batch file at 1024x768. When I changed it to 1440x900, it evidenced the exact same behaviour. There is a bug in the script itself for that resolution.

I don't know Perl and I don't have a runtime installed on my computer, so it's a bit hard for me to debug. Nevertheless, I have a powerful suspicion that the script is going awry in the MouseMoveAbsPix subroutine. It enters an until() loop on line 811, and I think the condition never evaluates true.

But why it's happening, why I've only seen it triggered with this one command, I have no idea. It's possible that it occurs with other commands as well. I probably haven't used every single command defined. Another command with the same co-ordinates ("Aim For Weapons", ID=543) works fine.

It's very strange that it happens only for that one command. I don't recall there being anything special about damage control.

Taking a quick look, I see it has an ID of 55 in the Stock CSV set. I also see some trigger maru specific code that does a general text inspection at the CSV set name to determine if it has "trigger maru" in it, and if it does, it treats 55 special during the tube specific code, which is weird because in my set, trigger maru damage management is still 55, in other words, 55 wasn't repurposed to tubes or anything in tm. So there could be a problem there.

One fix might be to make sure your CSV set name as referenced in the launch bat file doesn't say "trigger maru" which would cause it to be treated as stock (of course if you're used to running in TM mode, that might cause a bit of a shock.) Another option might be to change all instances of ID 55 to some other obscure number as mentioned above. Whenever you suspect something weird about the ID, change it, and be sure to change it in every CSV it might be referenced in, in both the ID column and the PARENT column.

Generally speaking most testing was done in stock, and TM was kind of tacked on and was never really fully vetted as well as it could have been.

Hope that's clear enough and leads you to a solution... sorry I can't even test this as I don't have a working microphone at the moment. I do on my laptop, if I have time I will try tomorrow!

[ferg]

Sorry, I am just logging off and heading to bed or I'd write a proper reply, Erik. I'll get to that tomorrow or Thursday depending. Thanks for taking the time to post.

I just wanted to share that I installed ActivePerl and enabled the debug output you had in that until loop. This is what I found interesting:

Mouse clicking at 336,871 for Damage Control Team (id=572)
17476==15292&&59637==63423
17039==15292&&60394==63423
16602==15292&&61151==63423
16165==15292&&61909==63423
15728==15292&&62666==63423
15291==15292&&63423==63423
14855==15292&&64181==63423
...and off it goes into an endless loop...

The second to last line is where the until loop is intended to exit, but of course it doesn't because 15291 is not 15292. I only looked at it for a minute or so, but off the cuff it looks like a rounding error to me.

[billko]

Originally Posted by ferg

Sorry, I am just logging off and heading to bed or I'd write a proper reply, Erik. I'll get to that tomorrow or Thursday depending. Thanks for taking the time to post.

I just wanted to share that I installed ActivePerl and enabled the debug output you had in that until loop. This is what I found interesting:

Mouse clicking at 336,871 for Damage Control Team (id=572)
17476==15292&&59637==63423
17039==15292&&60394==63423
16602==15292&&61151==63423
16165==15292&&61909==63423
15728==15292&&62666==63423
15291==15292&&63423==63423
14855==15292&&64181==63423
...and off it goes into an endless loop...

The second to last line is where the until loop is intended to exit, but of course it doesn't because 15291 is not 15292. I only looked at it for a minute or so, but off the cuff it looks like a rounding error to me.

hey nice catch!

[kraszus]

Hi. First, thanks for a great mod

I play Trigger Maru variant using 1680x1050 resolution. I have edited the main.cfg and the shspeech.bat accordongly:-

@cd dist
voice 1680x1050 "trigger maru" 1 right sh4

Everything works great except Heading Change requests and Depth Change requests. Eg. If I say 'heading left 10 degrees' it sets a heading about 60 degrees left instead of 10 degrees. Similarly with depth if asked to set a depth to 40meteres, it sets a depth to 80 or 90 metres.

I can see the mouse click on the dial and it is clicking in the wrong place.

Have I edited the files correctly?

PS. I should probably mention that I have also downloaded the SH3 variant and it works fine with the dials.