SUBSIM Radio Room Forums



SUBSIM: The Web's #1 resource for all submarine & naval simulations since 1997

Go Back   SUBSIM Radio Room Forums > Silent Hunter 3 - 4 - 5 > SH4 Mods Workshop
Forget password? Reset here

Reply
 
Thread Tools Display Modes
Old 03-22-10, 03:13 PM   #1
billko
中国水兵
 
Join Date: Jul 2007
Posts: 275
Downloads: 21
Uploads: 2
Default

Quote:
Originally Posted by ferg View Post
You're basically right, Billko. The problem does not affect "stock", but it does affect "trigger maru" (thus my own modified "trigger maru" also has the problem). However, I stand by my description of it as a bug since it occurs with an included data set. As far as I know, I haven't modified anything in the "trigger maru" set. I'm going to check that right now by snagging the file again and overwriting the "trigger maru" files to confirm it.

Edit: Confirmed. The problem exists in the provided "trigger maru" files. I'll see if I can figure it out. Thanks for the clue that it works with the stock data! With any luck I should be able to fix it.
Mucking around inside the changelog shows that the last version of TMO supported was 1.6. Also, the last version of SH4Speech seemed to have a different way of handling the TMO CSV files and warned of compatibility issues. (see first page, this topic)

Again, people here probably have updated CSV files that could save a lot of headache

I hope this helps.

Bill
__________________
Damage Control 1.1 - LeoVampire Edition - Can you trust the experience of your crew to inform you of how deep you can really dive?
billko is offline   Reply With Quote
Old 03-22-10, 03:40 PM   #2
ferg
Watch
 
Join Date: Dec 2007
Posts: 19
Downloads: 148
Uploads: 0
Default

Quote:
Originally Posted by billko View Post
Also, the last version of SH4Speech seemed to have a different way of handling the TMO CSV files and warned of compatibility issues. (see first page, this topic)
First page of this topic does not contain "TMO" or the phrase "trigger maru". I can't seem to find the reference. I'm not sure what you mean about a different way of handling the TMO CSV files.

There are slight differences between running sh4Speech in "stock" and "trigger maru" modes in the code, but nothing that looked like it would break anything. Looking at the source, I only noticed that torpedo tube handling is somehow different (probably to handle different tube cycling in TM). I've got tube cycling working well enough for me at this point, so that is not a concern.

Quote:
Again, people here probably have updated CSV files that could save a lot of headache
Totally, but I'm not sure anyone has put up with the headache and done it. If they have, why is there nothing on minsc's download page or in this thread? A Google search for "sh4speech tmo 1.9" finds only my own post asking if anyone has done an update. I tried the more general "sh4speech tmo" too, but no dice. If I can get it working to my satisfaction, I'll happily make my updates available to others.
ferg is offline   Reply With Quote
Old 03-22-10, 03:42 PM   #3
billko
中国水兵
 
Join Date: Jul 2007
Posts: 275
Downloads: 21
Uploads: 2
Default

Quote:
Originally Posted by ferg View Post
First page of this topic does not contain "TMO" or the phrase "trigger maru". I can't seem to find the reference. I'm not sure what you mean about a different way of handling the TMO CSV files.

There are slight differences between running sh4Speech in "stock" and "trigger maru" modes in the code, but nothing that looked like it would break anything. Looking at the source, I only noticed that torpedo tube handling is somehow different (probably to handle different tube cycling in TM). I've got tube cycling working well enough for me at this point, so that is not a concern.



Totally, but I'm not sure anyone has put up with the headache and done it. If they have, why is there nothing on minsc's download page or in this thread? A Google search for "sh4speech tmo 1.9" finds only my own post asking if anyone has done an update. I tried the more general "sh4speech tmo" too, but no dice. If I can get it working to my satisfaction, I'll happily make my updates available to others.
Darn it. If I had that mod I would do the same.
__________________
Damage Control 1.1 - LeoVampire Edition - Can you trust the experience of your crew to inform you of how deep you can really dive?
billko is offline   Reply With Quote
Old 03-23-10, 01:41 AM   #4
Chromius
Sailor man
 
Join Date: Aug 2009
Location: Manchester, NH
Posts: 43
Downloads: 151
Uploads: 0
Default

Has anyone got some modded files that work with RFB 2.0 (1680x1050) just trying to save myself time.
Chromius is offline   Reply With Quote
Old 03-23-10, 01:42 AM   #5
ferg
Watch
 
Join Date: Dec 2007
Posts: 19
Downloads: 148
Uploads: 0
Default

OK, well, this "damage control team" problem is a strange one. It turns out it has nothing to do with the CSV files. I thought the problem wasn't appearing in stock until I remembered that I had left the stock batch file at 1024x768. When I changed it to 1440x900, it evidenced the exact same behaviour. There is a bug in the script itself for that resolution.

I don't know Perl and I don't have a runtime installed on my computer, so it's a bit hard for me to debug. Nevertheless, I have a powerful suspicion that the script is going awry in the MouseMoveAbsPix subroutine. It enters an until() loop on line 811, and I think the condition never evaluates true.

But why it's happening, why I've only seen it triggered with this one command, I have no idea. It's possible that it occurs with other commands as well. I probably haven't used every single command defined. Another command with the same co-ordinates ("Aim For Weapons", ID=543) works fine.
ferg is offline   Reply With Quote
Old 03-23-10, 01:52 AM   #6
billko
中国水兵
 
Join Date: Jul 2007
Posts: 275
Downloads: 21
Uploads: 2
Default

Quote:
Originally Posted by ferg View Post
OK, well, this "damage control team" problem is a strange one. It turns out it has nothing to do with the CSV files. I thought the problem wasn't appearing in stock until I remembered that I had left the stock batch file at 1024x768. When I changed it to 1440x900, it evidenced the exact same behaviour. There is a bug in the script itself for that resolution.

I don't know Perl and I don't have a runtime installed on my computer, so it's a bit hard for me to debug. Nevertheless, I have a powerful suspicion that the script is going awry in the MouseMoveAbsPix subroutine. It enters an until() loop on line 811, and I think the condition never evaluates true.

But why it's happening, why I've only seen it triggered with this one command, I have no idea. It's possible that it occurs with other commands as well. I probably haven't used every single command defined. Another command with the same co-ordinates ("Aim For Weapons", ID=543) works fine.
wow, i'm not sure why it would be resolution-related because it's all just calculating ratios for mouse movement, but there's no denying there's something amiss! i'll have to think about that one. hopefully minsc will be by soon to bring to light the solution
__________________
Damage Control 1.1 - LeoVampire Edition - Can you trust the experience of your crew to inform you of how deep you can really dive?
billko is offline   Reply With Quote
Old 03-29-10, 02:57 AM   #7
minsc_tdp
XO
 
Join Date: Mar 2007
Posts: 411
Downloads: 1
Uploads: 0
Default

Ok guys this seemed like the best place to post this.

If anyone is having trouble with the new voice command system for SH5, and used my shSpeech, and you want to try it with SH5, check out this webpage as it has updated files for SH5.

http://knepfler.com/shSpeech


These were created by 7Infanterie19 not me, so please no emails! Unfortunately I have no time to support this or do really anything further on it, but 2.54 is quite stable. I haven't tested these new CSVs, so, good luck everyone!

Now, what's all this about damage control... I promise to try to look when I get a chance!
__________________
June 29 2016 - shSpeech v2.55 - Voice Command for Silent Hunter 4! View Thread
minsc_tdp is offline   Reply With Quote
Old 03-29-10, 03:17 AM   #8
minsc_tdp
XO
 
Join Date: Mar 2007
Posts: 411
Downloads: 1
Uploads: 0
Default

Quote:
Originally Posted by ferg View Post
OK, well, this "damage control team" problem is a strange one. It turns out it has nothing to do with the CSV files. I thought the problem wasn't appearing in stock until I remembered that I had left the stock batch file at 1024x768. When I changed it to 1440x900, it evidenced the exact same behaviour. There is a bug in the script itself for that resolution.

I don't know Perl and I don't have a runtime installed on my computer, so it's a bit hard for me to debug. Nevertheless, I have a powerful suspicion that the script is going awry in the MouseMoveAbsPix subroutine. It enters an until() loop on line 811, and I think the condition never evaluates true.

But why it's happening, why I've only seen it triggered with this one command, I have no idea. It's possible that it occurs with other commands as well. I probably haven't used every single command defined. Another command with the same co-ordinates ("Aim For Weapons", ID=543) works fine.
It's very strange that it happens only for that one command. I don't recall there being anything special about damage control.

Taking a quick look, I see it has an ID of 55 in the Stock CSV set. I also see some trigger maru specific code that does a general text inspection at the CSV set name to determine if it has "trigger maru" in it, and if it does, it treats 55 special during the tube specific code, which is weird because in my set, trigger maru damage management is still 55, in other words, 55 wasn't repurposed to tubes or anything in tm. So there could be a problem there.

One fix might be to make sure your CSV set name as referenced in the launch bat file doesn't say "trigger maru" which would cause it to be treated as stock (of course if you're used to running in TM mode, that might cause a bit of a shock.) Another option might be to change all instances of ID 55 to some other obscure number as mentioned above. Whenever you suspect something weird about the ID, change it, and be sure to change it in every CSV it might be referenced in, in both the ID column and the PARENT column.

Generally speaking most testing was done in stock, and TM was kind of tacked on and was never really fully vetted as well as it could have been.

Hope that's clear enough and leads you to a solution... sorry I can't even test this as I don't have a working microphone at the moment. I do on my laptop, if I have time I will try tomorrow!
__________________
June 29 2016 - shSpeech v2.55 - Voice Command for Silent Hunter 4! View Thread
minsc_tdp is offline   Reply With Quote
Old 03-31-10, 02:37 AM   #9
ferg
Watch
 
Join Date: Dec 2007
Posts: 19
Downloads: 148
Uploads: 0
Default

Sorry, I am just logging off and heading to bed or I'd write a proper reply, Erik. I'll get to that tomorrow or Thursday depending. Thanks for taking the time to post.

I just wanted to share that I installed ActivePerl and enabled the debug output you had in that until loop. This is what I found interesting:

Code:
Mouse clicking at 336,871 for Damage Control Team (id=572)
17476==15292&&59637==63423
17039==15292&&60394==63423
16602==15292&&61151==63423
16165==15292&&61909==63423
15728==15292&&62666==63423
15291==15292&&63423==63423
14855==15292&&64181==63423
...and off it goes into an endless loop...
The second to last line is where the until loop is intended to exit, but of course it doesn't because 15291 is not 15292. I only looked at it for a minute or so, but off the cuff it looks like a rounding error to me.
ferg is offline   Reply With Quote
Old 03-31-10, 02:41 AM   #10
billko
中国水兵
 
Join Date: Jul 2007
Posts: 275
Downloads: 21
Uploads: 2
Default

Quote:
Originally Posted by ferg View Post
Sorry, I am just logging off and heading to bed or I'd write a proper reply, Erik. I'll get to that tomorrow or Thursday depending. Thanks for taking the time to post.

I just wanted to share that I installed ActivePerl and enabled the debug output you had in that until loop. This is what I found interesting:

Code:
Mouse clicking at 336,871 for Damage Control Team (id=572)
17476==15292&&59637==63423
17039==15292&&60394==63423
16602==15292&&61151==63423
16165==15292&&61909==63423
15728==15292&&62666==63423
15291==15292&&63423==63423
14855==15292&&64181==63423
...and off it goes into an endless loop...
The second to last line is where the until loop is intended to exit, but of course it doesn't because 15291 is not 15292. I only looked at it for a minute or so, but off the cuff it looks like a rounding error to me.
hey nice catch!
__________________
Damage Control 1.1 - LeoVampire Edition - Can you trust the experience of your crew to inform you of how deep you can really dive?
billko is offline   Reply With Quote
Old 03-29-10, 03:10 AM   #11
minsc_tdp
XO
 
Join Date: Mar 2007
Posts: 411
Downloads: 1
Uploads: 0
Default

Quote:
Originally Posted by ferg View Post
Totally, but I'm not sure anyone has put up with the headache and done it. If they have, why is there nothing on minsc's download page or in this thread? A Google search for "sh4speech tmo 1.9" finds only my own post asking if anyone has done an update. I tried the more general "sh4speech tmo" too, but no dice. If I can get it working to my satisfaction, I'll happily make my updates available to others.
Nobody has ever bundled up an updated set of CSVs for versions of Trigger Maru past 1.6, hence there's nothing on the webpage about it. You might be the first to have bothered. PM me if you manage to get it working and have all your CSVs organized into a zip and I'm happy to post to the site.

That damage control bug is really scary. Seems like it is locking up - I'd bet voice.exe is running 100% CPU when this happens. Very ugly.
__________________
June 29 2016 - shSpeech v2.55 - Voice Command for Silent Hunter 4! View Thread
minsc_tdp is offline   Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 03:42 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright © 1995- 2025 Subsim®
"Subsim" is a registered trademark, all rights reserved.