Pacific environment 4 RELEASED

[Nisgeis]

Originally Posted by Syxx_Killer

Yes, that is what I am seeing. In shallow water if I am surfaced, I will see white lines around the bottom half of the sub, especially the stern areas. When submerged near the surface where I can see the sub with the camera there will be those white lines, mostly around the railings like you mentioned.

OK, after much experimentation I now know what is causing this. As far as I can tell there's some sort of glitch regarding the depth of water, which makes the shader blend in the sea bed at full strength around the very edge of the submarine. The sea bed is only renedered on the refrected part of the textures if the sea bed is 200m or less deep. This is why the problem only occurs when you are in shallow water. Also, rotating the camera, so looking at your sub with deep water in the background should get rid of the white lines.

Now I know what is causing the problem, I'm that one step closer to resolving it. It should only affect subs in shallowish waters though. Everyone else should be alright.

[kriller2]

Originally Posted by Nisgeis

OK, after much experimentation I now know what is causing this. As far as I can tell there's some sort of glitch regarding the depth of water, which makes the shader blend in the sea bed at full strength around the very edge of the submarine. The sea bed is only renedered on the refrected part of the textures if the sea bed is 200m or less deep. This is why the problem only occurs when you are in shallow water. Also, rotating the camera, so looking at your sub with deep water in the background should get rid of the white lines.

Now I know what is causing the problem, I'm that one step closer to resolving it. It should only affect subs in shallowish waters though. Everyone else should be alright.

HI Nisgeis,

That sounds great, we now have a explanation to why it happens, now we are a little step closer to a solution

Now I better get back to testing the new shader.. I have seen something strange when looking at a ship after a torpedo hit it, nothing serious but I need to test it some more to see if it's my texture making the problem or our water shader...

Will take a screenshot of it so you can take a look at it.

EDIT: here it is:

Now I got a snapshot of it:


I have never seen this before :hmm: is it our shader or is it the damage texture? - the strange thing is that if there is a explosion near by it looks like this, the screenshot is from the submarine torpedo school.


BTW your PM is full

[Syxx_Killer]

Originally Posted by Nisgeis

Can you post a screenshot showing these lines? I have not noticed them myself, but then I'm not very observant.

Here's a screenshot from the stock game, but I noticed the issue yesterday running PE3. That's what made me think to bring it up.



See that outline around the sub? This is also seen around ships and things like docks. It only happens at night.

[Orion2012]

Originally Posted by Syxx_Killer

Here's a screenshot from the stock game, but I noticed the issue yesterday running PE3. That's what made me think to bring it up.



See that outline around the sub? This is also seen around ships and things like docks. It only happens at night.

Kind of looks like a rim lighting effect.

[Nisgeis]

Originally Posted by kriller2

I have seen something strange when looking at a ship after a torpedo hit it, nothing serious but I need to test it some more to see if it's my texture making the problem or our water shader...

Hmmm, when the hole is applied to a hull, the damage mask is multiplied against the hull texture to make the damage appear. The 3d model is still the same, and I'm not sure where it gets the colour to apply to the masked off section... perhaps it's the water fog colour? Not sure about this one, will have to have a look at what it does with stock and compare it to see where it's getting that colour from.

BTW your PM is full

People keep filling it up! There's space now.

[Nisgeis]

Originally Posted by Orion2012

Kind of looks like a rim lighting effect.

That outline is there during day time as well. It's like a little hull wake effect. It's noticable at night like that as it's probably a bit too bright. It's definitely meant to be there. I could perhaps see if I can make it a bit less bright?

[Syxx_Killer]

Originally Posted by Nisgeis

That outline is there during day time as well. It's like a little hull wake effect. It's noticable at night like that as it's probably a bit too bright. It's definitely meant to be there. I could perhaps see if I can make it a bit less bright?

If it could be less bright, that would be good. It looks brighter in game than in screenshots. It just doesn't seem "natural".

[Nisgeis]

Originally Posted by kriller2

I have seen something strange when looking at a ship after a torpedo hit it, nothing serious but I need to test it some more to see if it's my texture making the problem or our water shader...

I took a look at this and I am fairly happy that it's a stock thing. Can you try testing it with stock? It's not something you would normally notice, as usually the damage hole is on the side of the ship. In that screen shot, it just so happened that the unusually shaped hull meant there was a blank part. It's quite noticable if you place a torpedo at the bow of a ship, then it becomes quite obvious.

Could you try it in stock and see if you get the same result as I did? That goes for anyone else too .

Thanks.

[Nisgeis]

Originally Posted by Sailor Steve

I agree. I usually argue for clarity in the water, since I've seen the bottom from the bridge of a destroyer when it was well over 100 feet deep.

BUT...at extreme angles I think reflection kills clarity. I don't think the bow of the sub could be seen like that from the periscope. It's a tough question, since I guess it's one or the other. Clear so you can see the cool sights in external views, or not clear so the periscope doesn't become a magic mirror, seeing all and knowing all?

After another seven hours slaving over a hot text file, I've discovered that the game engine only used the amount of water between the camera and the submarine's hull (or whatever object was being viewed) to calculate how clear the image was. I've managed to get it to now take into account the angle the light is striking the water as well as the amount of water between the camera and the object and I think it now blends much better.

You can now see you sub quite deep if you are looking straight down at it, but you can't see it from the side so easily. At very low angles, you can no longer see very much beneath the surface, even a ship's hull just below the water. I think this looks more realistic. You can still see a bit of your sub's bow from the periscope though.

Kriller has a range of experimental shaders to test and will no doubt get back to me with what settings work and what don't.

[kriller2]

HI Nisgeis, I like your new shaders so made some more work on the environment colours and textures, is there any way we can make the water less transparent? so that the water have a colour between the surface and the bottom, (see the last picture)

[Nisgeis]

Originally Posted by kriller2

HI Nisgeis, I like your new shaders so made some more work on the environment colours and textures, is there any way we can make the water less transparent? so that the water have a colour between the surface and the bottom, (see the last picture)

Just sent you experimental shader number 5. It has altered reflections, that are less distorted and give more detailed waves. The water colour should also be more representative of what is in scene.dat, so you shouldn't have to change your values too much - sorry if you already did!. The reflection brightness is also reduced a bit. I think it looks quite nice.

I've just co-incidentally been working on water fogging, as there is a disparity between stock above water transparency and below water transparency. Below water seems to be much cloudier that the above water view would suggest, so I've been trying to get a fogging effect on the refracted image, with the amount of water between the camera and the hull affecting how foggy the hull is.

I also discovered why torpedoes aren't visible under water, but haven't got a fix yet. It's not something that can be solved in the pixel shader though.

[vickers03]

Originally Posted by Nisgeis

I also discovered why torpedoes aren't visible under water, but haven't got a fix yet. It's not something that can be solved in the pixel shader though.

interesting:hmm: more details please

[Nisgeis]

Originally Posted by vickers03

interesting:hmm: more details please

The torpedo is rendered underwater, but it has no 'depth' information associated with it, so the game doesn't consider it close to the surface.

I don't know, but have a suspicioon as mentioned earlier, that the torpedo needs a unit_ship controller attached to it, but so far I haven't been able to spare any time to test that. I've spent about 30 hours on the shader code so far, so no free time .

[Orion2012]

Originally Posted by Nisgeis

The torpedo is rendered underwater, but it has no 'depth' information associated with it, so the game doesn't consider it close to the surface.

I don't know, but have a suspicioon as mentioned earlier, that the torpedo needs a unit_ship controller attached to it, but so far I haven't been able to spare any time to test that. I've spent about 30 hours on the shader code so far, so no free time .

WOW, thats way more patience then I have!

Does anyone know, or tested the new PE with OM?? (op monson)

[kriller2]

Originally Posted by Nisgeis

The torpedo is rendered underwater, but it has no 'depth' information associated with it, so the game doesn't consider it close to the surface.

I don't know, but have a suspicioon as mentioned earlier, that the torpedo needs a unit_ship controller attached to it, but so far I haven't been able to spare any time to test that. I've spent about 30 hours on the shader code so far, so no free time .

Your new work is awesome, here is a litlle screenshot from the new more detailed ripples on the water: ( its hard to show on a screenshot though..)


Thanks for workin on this