SUBSIM: The Web's #1 resource for all submarine & naval simulations since 1997 |
|
06-02-19, 09:58 AM | #1 | |
中国水兵
Join Date: Jun 2009
Location: Uppland, Sweden
Posts: 278
Downloads: 48
Uploads: 0
|
Quote:
Counterproductive...? I take that as an insult. Do you even know what that word mean? I may possibly have made something that you don't want to use. I use it though. That's pretty much all that matters for me. If any one else wants to use it - fine. If anyone else don't want to use it - perfect. I don't care. I have given all the code away into the public domain for anyone to fiddle with and to merge with hsies work if that's wanted. How is that counterproductive?! Blame yourself or anyone else that have done nothing in this matter for being counterproductive instead. D*mn I'm pissed... counterproductive my *ss. Last edited by Fader_Berg; 06-02-19 at 10:08 AM. |
|
06-02-19, 10:15 AM | #2 | |
Officer
Join Date: Sep 2012
Posts: 249
Downloads: 126
Uploads: 0
|
Quote:
Creating something that isn't compatible to the standard is counterproductive because very few people are using it...
__________________
My Mediafire Page Join the Real ASW Mod Discord-Server: https://discord.gg/Yg5ZE25 |
|
06-02-19, 10:25 AM | #3 |
中国水兵
Join Date: Jun 2009
Location: Uppland, Sweden
Posts: 278
Downloads: 48
Uploads: 0
|
The fact that it's created for a small audience (if any at all) doesn't make it counterproductive. I'm sorry.
|
06-02-19, 03:24 PM | #4 |
CTD - it's not just a job
|
I have a quote in my signature from Jimbuna that perfectly fits this. I would also like to thank Fader_Berg for what he has accomplished with this. I would also like to thank Stiebler and h.sie for what they have done - in fact, I'd like to thank ~ALL~ the modders who have done anything for the modding community, conforming to "standards" or not (by whose definition are these "standards", btw?). It ain't easy doing this modding stuff, because as can be seen, someone seems quick to criticize. Do it constructively and politely please... whoops - my soapbox collapsed from my body weight... sorry.
|
06-03-19, 03:00 PM | #5 | |
Sonar Guy
Join Date: Oct 2013
Posts: 377
Downloads: 64
Uploads: 0
|
Quote:
I do sympathize here as concerns to working with other people's code that may not have the same disciplines as yourself, same education or even understanding of design principles. It's quite frustrating (not to say that either of those developers in question used bad practices as I haven't spent much time looking at the source. I do know however, that working with assembly is so low-level that any design concepts, if they can be applied, that are common with higher level languages can't be applied to assembly.). I'd really hate to design a whole application in assembly to begin with, why not read the byte values in a higher level language and output the modified bytes to executable? |
|
06-03-19, 04:31 PM | #6 | ||
中国水兵
Join Date: Jun 2009
Location: Uppland, Sweden
Posts: 278
Downloads: 48
Uploads: 0
|
Quote:
Quote:
I tried at first. In some parts of the patSH3r source code you can still see that I tried it. It's mentioned in the comments (which I've forgotten to update when I gave up). If I make one patch I might end up having to write two or more patches to make it compatible with hsies. One when hsie.A i enabled. One more when hsie.A is disabled. Fu*k... it crashes. This because a variable in the hsie.A-code are also being used in hsie.C and -F-code too, and doesn't get updated correctly now. I have to figure out how this variable works in fragmented, disorganized and very sparse commented code in gerrman. By the way... which other hsie-features uses this variable also?! Not to mention all variables that are being used between A, B, G and O that I may have missed, and doesn't result in a crash. That's gonna affect the game somehow. It probably ends up in some "when I got 56% oxy left and the clock is 12:42 a friday the submarine crashdives"-bug. I just puked in my mouth. No! If I have to fill my my spare time with something extremely hard and boring. I rather work extra and make some money instead. Last edited by Fader_Berg; 06-03-19 at 04:49 PM. |
||
06-03-19, 05:19 PM | #7 | |
Sonar Guy
Join Date: Oct 2013
Posts: 377
Downloads: 64
Uploads: 0
|
Quote:
This sounds like is using global variables here when he should be using local variables? Or he is referencing the same variable from the same package over and over again? This is a design issue. What about copying these globals to local variables in the scope you need to use it in, and edit them as such, not affect the global variable itself (assuming you don't need the edits on these variables to be outside of your current scope)? |
|
06-03-19, 10:17 PM | #8 | |
中国水兵
Join Date: Jun 2009
Location: Uppland, Sweden
Posts: 278
Downloads: 48
Uploads: 0
|
Quote:
To be able to remedy this I (or anyone else for that matter) need to analyze and understand pretty much everything he has written. Since, like I told you, the code is very sparsely commented in german (with even most of the variable names being made in german, scattered around the source in a non logical way). it's damn frustrating and hard to cope with. It's not impossible off course, Anyone can do it. It just takes time and effort I'm not willing to invest. Last edited by Fader_Berg; 06-03-19 at 10:49 PM. |
|
|
|