[REL] Fix for glowing water around objects in SH4 1.4

[jaketoox]

I thought that the glow would look better if it wasn't so intensive as it is...so it had to be tuned down a bit...hope you can see the difference in these pictures...

-Before-




-After-




And here's the FIX , JSGME ready.

Hope you enjoy, skippers



Jake

[DrBeast]

Neat! Gonna grab this for when I finally install the new patch (read: ROW is 1.4-ready)

[Reece]

Nice quick fix! Thanks much!!

[pythos]

I kinda like the look of Cherenkov radiation around my sub. Gives me a feeling the plants are working fully. Oh wait, these are diesle boats, not Nukes.

In truth, unless stopped a vessle in the water is surounded by a "barrier" of froth, and at night this froth is of a greenish color especially in the propwash.

Sh4 got this kinda right, but your mod should help.

[kriller2]

Great work Jaketoox! You have many talents. Have you heard anything from Leo? - I am abit worried, haven't heard anything for almost a week now.
Kriller

[jaketoox]

No i have not heard.......i guess (and hope) that he's just busy with ROW, and in good health..

Jake

[Wilcke]

@ jaketoox

Thank you!

[Anvart]

"Patch v1.4:
...
CHANGES:
...
· Improvements to Water rendering
..."
Return to 1.3 ... ?
With my video card i have no "intensive glow" ...

[ATR-42]

Originally Posted by Anvart

"Patch v1.4:
...
CHANGES:
...
· Improvements to Water rendering
..."
Return to 1.3 ... ?
With my video card i have no "intensive glow" ...

what card are you using Anvart? what are your general graphics settings?

i want to lose the brightly glowing outlines too but am reluctant to undo any water rendering changes as well....... tough call.

[jaketoox]

There are only few lines added by devs in this file compared to stock 1.3 file;those lines are also only differences between 1.3 and 1.4 for this file. What i changed there is marked as red. My opinion is that you will not lose any other water rendering improvments by using this mod... glow is not removed, only made it less visible.


//[ser] Increase opacity near intersections to make water edge more visible
float shallowfactor = saturate(1/(depthlength*40 + 1));
//[ser] Attempt a pseudo-antialiasing by decreasing opacity smoothly near zero-depth
shallowfactor = saturate(shallowfactor - pow(shallowfactor,4))*1.25;
depthlength = saturate(depthlength/maxDist + shallowfactor);



//[ser] Simulate foam at shallow depths
Color.xyz = Color.xyz*(1-shallowfactor) + shallowfactor*0.3;//*(AmbientColor.xyz + (AmbientColor.x+AmbientColor.y+AmbientColor.z))*0. 25*2


Jake

[Archie]

Thx Jake! Only problem is when I load this up , for some weird reason my FPS goes down, took it off and things are back to normal....... guess im stuck with the chernobyl effect around my subs

[jaketoox]

Originally Posted by Archie

Thx Jake! Only problem is when I load this up , for some weird reason my FPS goes down, took it off and things are back to normal....... guess im stuck with the chernobyl effect around my subs

Wasn't it you who had the same problem with stock 1.3 file too? What is your hardware configuration (cpu, gfx card)? I'm running with P4 2.533 oc'd to 2.8, 1.2G memory and Nvidia 7600gt 512m, and have not FPS drop with this.

BTW is there anyone else having FPS drop??


Jake

[Archie]

Originally Posted by jaketoox

Wasn't it you who had the same problem with stock 1.3 file too? What is your hardware configuration (cpu, gfx card)? I'm running with P4 2.533 oc'd to 2.8, 1.2G memory and Nvidia 7600gt 512m, and have not FPS drop with this.

BTW is there anyone else having FPS drop??


Jake

Nope not me, I have only struck this since patching to 1.4. I run a dual core e6600 with 4 Gig RAM and an 8800 Ultra card welded to an asus p5w deluxe mobo, I can even run FSX on med to high settings without it breaking too much of a sweat, so I don't believe its my hardware. Maybe my settings perhaps? ill play around with sh4 and see, perhaps its even a conflict with part of a mod i am running? I'll start a few test runs and see how we go.....

EDIT PART 1 : Ok, took out your ROW New Seafoam which I was using and put your fix back in and that seemed to do the trick, problem is, I really like your ROW Seafoam jake, so i'd rather have the radioactive glow now and again than lose the seafoam file, oh well....

[jaketoox]

..what comes to my mind now,when you have nvidia card...is there any chance that you have transparency AA setting on in your card's settings?...just a thought..


Jake

[Archie]

Originally Posted by jaketoox

..what comes to my mind now,when you have nvidia card...is there any chance that you have transparency AA setting on in your card's settings?...just a thought..


Jake

I'll check hang on a minute.... Yes, set to 'Multisampling', should I turn it all off and let the application run the settings?