[REL] Multiple UIs for SH5 with TDC

[TheDarkWraith]

Originally Posted by Defiance

just noticed a major bug in the destroyed marks. When a destroyed mark is created it was also creating a new nav fix (if real nav was enabled)

I just noticed this yesterday as I was making v6.9.0. Thanks for the report though

Originally Posted by Magic1111

Hi TDW!

I´m very glad that you like my suggestion!

Another question is in this context, can we have a new UserOption, for example:

"Is SOAN/Charts enable (tab showing) at Game/Savegame Start (Yes/No)"

If yes, then I always see at the left side on the screen the Tab from charts and SOAN and I can easy it dragged in to the middle of the screen and then I can click on the name of the identified unit and SOAN flip to the correct unit!

I have a better idea:

A new user option has been added to v6.9.0: AutoEnableChartsOpenSOANToIdentifiedUnit

This user option has been added to the SOAN tab in the user option's editor/viewer app

If WEPS identifies the target and this new user option is True then:
- charts are enabled if not already
- SOAN is set to the unit
- SOAN is opened

You will still have to drag SOAN from the left side of the screen if it isn't already out on the screen

I'm thinking about adding another new user option. This user option will automatically enable charts when entering a scope station (periscope, obs scope, UZO)

EDIT:

added a new user option. This user option will control the enabling of the charts upon entering a scope station (attack, obs, or UZO).
Default value is disabled (False) (AutoEnableChartsOnScopeStation)

I find this new user option above handy

[TheDarkWraith]

v6.9.0 test 2 available here: http://www.gamefront.com/files/20965...ith_Test_2_zip

This has to be enabled after v6.8.0. Say yes to all conflicts in JSGME

NOTE: backup your ship's journal before enabling this! I haven't finalized v7 of the ship's journal format yet

v6.9.0 - (Real nav only) fixed bug of when destroyed mark was created a new nav fix was also created
- (Real nav only) all marks no longer show nautical time and GMT time. They show the time the digital clock mode is set to (Naut or GMT)
- (Real nav only) changing digital clock mode (Naut or GMT) will automatically update all marks with new timestamp
- Changing digital clock mode (Naut or GMT) will change the timestamps in the messagebox and the ship's journal
- Ship's journal current version is now v7
- While editing a mark the ability to switch clock mode (Naut or GMT) is disabled
- added a new user option. This user option will control the auto enabling of the charts and opening SOAN to identified unit upon WEPS-->Torpedo attack-->Ship identification order given. Default value is disabled (False) (AutoEnableChartsOpenSOANToIdentifiedUnit)
- added a new user option. This user option will control the enabling of the charts upon entering a scope station (attack, obs, or UZO). Default value is disabled (False) (AutoEnableChartsOnScopeStation)
- revised Ship's journal viewer app to new ship journal version (v7)
- revised TDWSOAN.DLL for support of new user option AutoEnableChartsOpenSOANToIdentifiedUnit
- (Real nav only) added more debug output at game start when all the marks are created to try and figure out why some users marks don't show until a kill is made
- added more debug output to SOAN to try and figure out why some users Additional info button on SOAN doesn't work
- fixed bugs in OptionsFileEditorViewer app relating to culture specifics

[ZL2BMH]

Thank you TDW. Your work and dedication is simply amazing, Eoweth told me about the work you have done and I am pleased to say, as a novice, I have all your mods, which I'm really thankful for.

Regards,
Zl2bmh

[torr]

Hi TDW
This patch 6.9.0 repair bug Editor(culture specific - "Invalid entry found.MIN value not a float Line read was #VALUES=MIN|0.0 @ line number 110."
) - successfly

I have W7 - 64bit - lang Czech

THX

[Magic1111]

Originally Posted by TheDarkWraith

I have a better idea:

A new user option has been added to v6.9.0: AutoEnableChartsOpenSOANToIdentifiedUnit

This user option has been added to the SOAN tab in the user option's editor/viewer app

If WEPS identifies the target and this new user option is True then:
- charts are enabled if not already
- SOAN is set to the unit
- SOAN is opened

You will still have to drag SOAN from the left side of the screen if it isn't already out on the screen

I'm thinking about adding another new user option. This user option will automatically enable charts when entering a scope station (periscope, obs scope, UZO)

EDIT:

added a new user option. This user option will control the enabling of the charts upon entering a scope station (attack, obs, or UZO).
Default value is disabled (False) (AutoEnableChartsOnScopeStation)

I find this new user option above handy

Hi TDW!

Wonderful news, that´s exactly what I want!!!

Can I enable v6.9.0 test2 during Mid-Patrol or only in bunker/port?

Best regards,
Magic

[Silent Steel]

This is deeeeep...



(NewUIs_TDC_6_8_0_ByTheDarkWraith\Dials\German\met ric\briklebritt)

[Magic1111]

Originally Posted by TheDarkWraith

- added a new user option. This user option will control the auto enabling of the charts and opening SOAN to identified unit upon WEPS-->Torpedo attack-->Ship identification order given. Default value is disabled (False) (AutoEnableChartsOpenSOANToIdentifiedUnit)

- added a new user option. This user option will control the enabling of the charts upon entering a scope station (attack, obs, or UZO). Default value is disabled (False) (AutoEnableChartsOnScopeStation)

Can I set both new UserOptions to "True" at the same time? Or must one of the new UserOptions set to "False" (when the other is set to true)?

[Magic1111]

Originally Posted by Silent Steel

This is deeeeep...



(NewUIs_TDC_6_8_0_ByTheDarkWraith\Dials\German\met ric\briklebritt)

I think "KM" is the short for "Kriegsmarine" (german word for Navy), not for "Kilometers"!

Best regards,
Magic

[TheDarkWraith]

Originally Posted by Magic1111

Hi TDW!

Wonderful news, that´s exactly what I want!!!

Can I enable v6.9.0 test2 during Mid-Patrol or only in bunker/port?

Best regards,
Magic

I don't see why you can't at anytime. The ship's journal is now at v7 format so it will automatically convert your old journal to the new version. Nothing has changed that impacts a campaign. All the changes are cosmetic in nature (to the game). Yes, you should be fine

Originally Posted by Magic1111

Can I set both new UserOptions to "True" at the same time? Or must one of the new UserOptions set to "False" (when the other is set to true)?

Yes you can Do you think I need another new user option that automatically disables the charts when you leave a scope station (like I did for the periscopes by having them automatically lower)?

Originally Posted by torr

Hi TDW
This patch 6.9.0 repair bug Editor(culture specific - "Invalid entry found.MIN value not a float Line read was #VALUES=MIN|0.0 @ line number 110."
) - successfly

Thanks for the report Can you do a little test for me? Find any value that is a float (has a decimal point) and change it's value. I recommend using the most fuel efficient speed (under the Fuel tab). Change it's value to say 10 and save the change (File-->Save). Close the app. Reopen the app and open your options file and ensure there are no errors while it's opening it.
Did you notice that I fixed the app in the regards that it shows numerical formatting in your specific culture? For Europeans this means the American symbol for denoting decimal places (.) now shows the correct symbol for you all (,)

EDIT:

- added a new user option. This user option will control the disabling of the charts when leaving a scope station (attack, obs, or UZO). Default value is disabled (False) (AutoDisableChartsOnScopeStationLeave)

[Silent Steel]

Originally Posted by Magic1111

I think "KM" is the short for "Kriegsmarine" (german word for Navy), not for "Kilometers"!

Best regards,
Magic

Still. Isn't it a bit confusing?
I'm not sure if die Marine used such an abbreviation like 'KM'?
On dials?
Someone?

[TheDarkWraith]

Originally Posted by oakdesign

Third issue
the t time parameter value for waiting on the execution of the next automation call is doubled
i.e

Report_position_deadreckoning,0,0,0,0,0,0,300
Loop,-1,0,0,0,0,0,0

Should invoke a looped dead reckon fix every 5 minutes. But it is invoked every 10 minutes.
Ok update on the last issue, after having a closer look into the TheDarkWraithAutomation.py it's now clear how the loop command is handled and just adding a simple
Wait,0,0,0,0,0,0,0
at the beginning of the commands list will clear the additional wait time that was taken over into the next Loop.

This really irked me as that is not how it's supposed to be working (you shouldn't have to add another command to make it work correctly). Upon looking back over my Automation code I saw a big fat error in the Update method dealing with the loop command. That error tells me why you were having to do this. When the loop command was encountered it was automatically setting the command index to 0 AND then setting the timer to command 0's wait time That is incorrect. I've changed the code to do what I intended it to do.
This change results in the loop command now having a t time that can be specified and it being the ONLY command who's t time is used when it's the last command (all other commands t time is ignored when they are the last command).
Now when a loop command is encountered the Update method will set the timer to the loop command's t time then it will update the command index to 0 (first command). That is how it was supposed to be working all this time.

I've updated Automation's documentation to reflect this:

; Loop,x,0,0,0,0,0,t - loop this automation script x times before stopping. If x = -1 then it will loop forever until stopped by user. NOTE: if this is the last command it's t time WILL be considered


Looking into Report_position_celestial within a Script running at TC>128 causing exceptions now

[Rongel]

I made a quick test with the new mod version, the OptionsFileEditor works now (didn't work before) and I also got the "Additional Info" in SOAN. Thanks!

[TheDarkWraith]

Originally Posted by Rongel

I made a quick test with the new mod version, the OptionsFileEditor works now (didn't work before) and I also got the "Additional Info" in SOAN. Thanks!

Thanks for the feedback Still not sure why the additional info wasn't working for you before. All I did was add more debug output to it so I could possibly see what was going on.

[TheDarkWraith]

Originally Posted by oakdesign

Second issue:
Calls on Report_position_celestial within a Script running at TC>128 raise an exception and stops script execution.
No DbgView entry when execption is thrown.
Below is the DebugScript output:

this was a hard one to figure out I see why it does this now and it's because of my error. When I'm grabbing the weather info there's a chance that it could try to read a journal entry that it's not supposed to read (incorrect journal entry type). I will correct this

[TheDarkWraith]

v6.9.0 test 3 available for testing here: http://www.gamefront.com/files/20966...ith_Test_3_zip

This should fix all the errors that have been reported now. Let me know if there are any new ones (hopefully not).

The quicker we can validate this the quicker I can release this new version. v6.8.0 needs to be replaced quickly due to the errors/bugs in it


v6.9.0 - (Real nav only) fixed bug of when destroyed mark was created a new nav fix was also created
- (Real nav only) all marks no longer show nautical time and GMT time. They show the time the digital clock mode is set to (Naut or GMT)
- (Real nav only) changing digital clock mode (Naut or GMT) will automatically update all marks with new timestamp
- Changing digital clock mode (Naut or GMT) will change the timestamps in the messagebox and the ship's journal
- Ship's journal current version is now v7
- While editing a mark the ability to switch clock mode (Naut or GMT) is disabled
- added a new user option. This user option will control the auto enabling of the charts and opening SOAN to identified unit upon WEPS-->Torpedo attack-->Ship identification order given. Default value is disabled (False) (AutoEnableChartsOpenSOANToIdentifiedUnit)
- added a new user option. This user option will control the enabling of the charts upon entering a scope station (attack, obs, or UZO). Default value is disabled (False) (AutoEnableChartsOnScopeStation)
- revised Ship's journal viewer app to new ship journal version (v7)
- revised TDWSOAN.DLL for support of new user option AutoEnableChartsOpenSOANToIdentifiedUnit
- (Real nav only) added more debug output at game start when all the marks are created to try and figure out why some users marks don't show until a kill is made
- added more debug output to SOAN to try and figure out why some users Additional info button on SOAN doesn't work
- fixed bugs in OptionsFileEditorViewer app relating to culture specifics
- added a new user option. This user option will control the disabling of the charts when leaving a scope station (attack, obs, or UZO). Default value is disabled (False) (AutoDisableChartsOnScopeStationLeave)
- fixed bug in Automation dealing with the loop command. Bug was when loop command was encountered it was setting the command index to 0 (start of commands) and setting the timer to command 0's wait time. Then when command 0 was executed the timer was set to command 0's wait time again. The fix for this has resulted in Automation's Wait command now being able to specify a t time. This fix also results in the Wait command being the ONLY command in Automation who's t time will be considered when it's the last command.
- fixed bug when an Automation command would 'request' weather info the script would stop