error in sub UPC files: no definitions for deck watch compartment

Ichthyos · 01-31-18, 08:56 PM

I just noticed that all the US subs are missing a definition in their .UPC files for the "Deck Watch" compartment.

it's even kinda hinted at in the notes near the top of each file:

;------------------------------------------------------------
; COMPARTMENTS STRUCTURE
;------------------------------------------------------------

; Compartments Functional Types
;
; FunctionalType= BowTorpedoRoom
; FunctionalType= SternTorpedoRoom
; FunctionalType= PropulsionRoom
; FunctionalType= SensorsRoom
; FunctionalType= CommandRoom
; FunctionalType= DamageControlRoom
; FunctionalType= ObservationRoom - Do we need this separate from SensorsRoom?
; FunctionalType= ArtilleryRoom
; FunctionalType= FlakRoom

it's the observationRoom. to answer a long gone and buried developer question... YES, you needed that separate from the SensorsRoom.

evidently nobody ever answered them, so they just left that out of the definition file.

look for yourself. Pick a sub and open the .upc file associated with it. You will find there is no room other than the command room that is defined to have 3 leaders and 9 crew. Nor are there any definitions for crewmember slots for the observationroom (deck watch).

so... how does it even work? is there some default template somewhere it falls back on? and what values is it using? I gather it likely uses watch statistic at a high level. since the dev asked if they needed it separate from the sensor room, I'd wager it ended up using the same values as those for the sensor room (electrics 0.5, watch 0.5) but who knows?

I can't be the only one who noticed this?

01-31-18, 08:56 PM	#1
Ichthyos Seaman Join Date: Jan 2018 Posts: 38 Downloads: 4 Uploads: 0	error in sub UPC files: no definitions for deck watch compartment I just noticed that all the US subs are missing a definition in their .UPC files for the "Deck Watch" compartment. it's even kinda hinted at in the notes near the top of each file: ;------------------------------------------------------------ ; COMPARTMENTS STRUCTURE ;------------------------------------------------------------ ; Compartments Functional Types ; ; FunctionalType= BowTorpedoRoom ; FunctionalType= SternTorpedoRoom ; FunctionalType= PropulsionRoom ; FunctionalType= SensorsRoom ; FunctionalType= CommandRoom ; FunctionalType= DamageControlRoom ; FunctionalType= ObservationRoom - Do we need this separate from SensorsRoom? ; FunctionalType= ArtilleryRoom ; FunctionalType= FlakRoom it's the observationRoom. to answer a long gone and buried developer question... YES, you needed that separate from the SensorsRoom. evidently nobody ever answered them, so they just left that out of the definition file. look for yourself. Pick a sub and open the .upc file associated with it. You will find there is no room other than the command room that is defined to have 3 leaders and 9 crew. Nor are there any definitions for crewmember slots for the observationroom (deck watch). so... how does it even work? is there some default template somewhere it falls back on? and what values is it using? I gather it likely uses watch statistic at a high level. since the dev asked if they needed it separate from the sensor room, I'd wager it ended up using the same values as those for the sensor room (electrics 0.5, watch 0.5) but who knows? I can't be the only one who noticed this?