[WIP] Mega-Mod for SH5

[stoianm]

Look at my control panel... see careful all i have installed like ''Microsoft Visual ....'':



Search in your Control panel and see if you have something microsoft visual diferent from me... if yes try to unninstal and try again the game... i remember that long time ago some people had CTDs because of an Microsoft redistributable... but i do not remember what was the exact name

[Agima]

Originally Posted by stoianm

Look at my control panel... see careful all i have installed like ''Microsoft Visual ....'':

[PIC]

Search in your Control panel and see if you have something microsoft visual diferent from me... if yes try to unninstal and try again the game... i remember that long time ago some people had CTDs because of an Microsoft redistributable... but i do not remember what was the exact name

Mines is pretty similar to yours, but not exactly the same...

[stoianm]

Originally Posted by Agima

Mines is pretty similar to yours, but not exactly the same...

unninstall the first one and try again the game... if is not working i have no other ideeas... seems like you said incompatibility between tdw uis and your compueters or sistem like in the church situation

EDIT: i just found the thread... the 'Visual C++ 2008 Redistributable 9.0.30729.4974 runtime' was the one who made CTDs... but i see you do not have this one... i have no other ideea... sorry

[Trevally.]

This is the version that causes the issues
Visual C++ 2008 Redistributable 9.0.30729.4974



Edit: stoianm

[stoianm]

Originally Posted by Trevally.

Edit: stoianm

yes ... i just readed old posts and i saw how manny problems you had to make this work... so you were the one that found this dam redistributable?

[Trevally.]

Originally Posted by stoianm

yes ... i just readed old posts and i saw how manny problems you had to make this work... so you were the one that found this dam redistributable?

No it was Seeder and SubV

[Agima]

Originally Posted by Church SUBSIM

Wow - that is the exact same issue I have with MO or the NewUI's, but I can't tell why. I have been able to run both mods without issues since TDW released 6.3.7 and then one day ... lockup when I sink a ship.

I even reinstalled windows 7 (x64) again ... fresh install, bought a new version of the game (disk this time instead of DL).

Sink a ship .. win a boobie prize. ;(

Originally Posted by Graf

I've uninstalled MO for now. I've tried everything with it but something in it does not agree with my system. I tried MO alone and still I have trouble leaving port with GFX hangups and CTDs. Everything imaginable goes wrong with MO on my system tho I love playing it when I can.

As of now I've disabled MO and currently playing a stable game with individual mods. I wish I could play MO but sadly it looks as tho I will not be able to.

GOOD NEWS! (kind of) Church SUBSIM & Graf!

I've been able to sink a ship with either (no other mods)
- Magnum Opus+patch2
and/or
- NewUIs_TDC_6_4_0_ByTheDarkWraith

Like I suspected, since Church said that he had the same problem with only the NewUIs, I figured out that this mod must be the one that was causing us thoses freeze when a torpedoe impact a ship, since the NewUIs are within Magnum Opus too.

So with trials and errors, I've removed some files from the NewUIs mod, one at the time, and finally nailed the one that cause the crash! The file is named "Page captain log.py".

If you want to test this out, to see if my temporary "solution" is not just specific to my computer, follow those instructions :

- Deactivate all mods in JSGME
- From within JSGME, right click on Magnum Opus and/or NewUIs_TDC_6_4_0_ByTheDarkWraith and delete them
- Unpack a brand new Magnum Opus, patch it to v0.0.2
- Unpack a brand new NewUIs_TDC_6_4_0_ByTheDarkWraith
- In BOTH of those mods folders (if you plan to install both), find the files "Page captain log.py" that are located in Data/Scripts/Menu and delete them
- Install and activate Magnum Opus. Do the same with NewUIs_TDC_6_4_0_ByTheDarkWraith
- Start SH5, start a new campaign, skip the tutorial
- When in port, save the game, then quit it.
- Start SH5, load the savegame, select your mission
- Then find a ship and sink it, hopefully without a game freeze!

Now, I know this is a temporary workaround, because "Page captain log.py" must be important and do something.

But at least I've pinned point the potential source of the problem. Then again, this file, or something in our own computer, must interfere with it, and that, is out of my knowledge and I just don't know what to do from here.

Maybe TheDarkWraith have an hypothesis ob this, since he created the mod!

[Church SUBSIM]

If this in fact works ... you will be my personal SH5 god, right next to TDW.
Will try it later tonight when I have the time.

Thanks!

[Church SUBSIM]

Originally Posted by Agima

- In BOTH of those mods folders (if you plan to install both), find the files "Page captain log.py" that are located in Data/Scripts/Menu

I take it you want us to delete that?

[Scrapy]

i get a crash when sinking a ship also.. it does not happen all the time, but it happens ALOT.

about to remove all mods and give it a go even though i hate the idea of no mods.

@Agima
I tried your method and renamed Page captain log.py to Page captain log.py.DISABLE, after loading a game there was a window pop-up, title said (OK), there where 2 boxes left and right both had the text (OK), and 3 confirm boxes at the bottom, i think they where ( DECLINE - CANCEL - ACCEPT )

clicking either of these buttons did nothing, and could not remove the box... too annoying to attempt to play like that so i have no idea if changing that file would of fixed it.

*EDIT*
i need to read properly next time :P, sorry i have been awake a little over 24 hours currently.

this time i did what you said, and *DELETED* the files from the mods folders before installing (silly me did not stop to think the game had this file to begin with).

now that box i was talking about is gone.... AND, i was just able to sink 8 ships in a row, and no crash YAY, altho i did freeze for a second or two here and there.

so far so good... will keep ya posted

[Agima]

Originally Posted by Church SUBSIM

I take it you want us to delete that?

Yes! Delete them!

[TheDarkWraith]

Open the suspected Page captain log.py file with notepad and post the first few lines of it please. Give me about the first 20 lines from the file.

[Agima]

Originally Posted by TheDarkWraith

Open the suspected Page captain log.py file with notepad and post the first few lines of it please. Give me about the first 20 lines from the file.

Here are the first lines of that .py file. I've compared both version (NewUIs and the one in Magnum Opus) and they are the same, at least for those first lines, I haven't compared the rest :

import clr
clr.AddReference("System")
from System import DateTime

from menu import Menu
from game import Game

captainloglistbox = None
IDSTR_ShipSunk = 8855
IDSTR_SunkAtPosition = 8856
IDSTR_Tonnage = 8857
IDSTR_Tons = 8858
IDSTR_WEPS = 8859
lastentrydatetime = None

from TheDarkWraithUserOptions import GetTimeZoneModifier


def InitializeScript():
Menu.PageActivated += PCL_Menu_PageActivated
Menu.PageDeactivated += PCL_Menu_PageDeactivated

PCL_Menu_PageActivated( Pagecaptainlog )


def StartGame():
# get the captain's log listbox with items control
global captainloglistbox
for ctrl in Pagecaptainlog_CaptainLog.Controls:
if ctrl.Name == "Captain'sLog":
captainloglistbox = ctrl
break

global lastentrydatetime
lastentrydatetime = None

[TheDarkWraith]

I need to see the very first few lines also - my header info I put in all my files

[Agima]

Oups sorry!

Here the whole thing. This is the content of the NewUIs_TDC_6_4_0 Page Captain Log.py file.

# Edited by TheDarkWraith for NewUIs_TDC_6_4_0
# Edited on 03/18/2010 @ 1700
#
# Copyright notice:
# The code changes made to this file are the intellectual property of TheDarkWraith and may not be used, modified, or duplicated in whole,
# or in part, without the express written permission of TheDarkWraith. The code changes made to this file may not be used in any commercial
# application of any form without the express written permission of TheDarkWraith.


import clr
clr.AddReference("System")
from System import DateTime
clr.AddReference( "TDWUtils" )
from TheDarkWraith.SilentHunter5 import TDWUtils

from menu import Menu
from game import Game

captainloglistbox = None
IDSTR_ShipSunk = 8855
IDSTR_SunkAtPosition = 8856
IDSTR_Tonnage = 8857
IDSTR_Tons = 8858
IDSTR_WEPS = 8859
lastentrydatetime = None

from TheDarkWraithUserOptions import GetTimeZoneModifier


def InitializeScript():
Menu.PageActivated += PCL_Menu_PageActivated
Menu.PageDeactivated += PCL_Menu_PageDeactivated

PCL_Menu_PageActivated( Pagecaptainlog )


def StartGame():
# get the captain's log listbox with items control
global captainloglistbox
for ctrl in Pagecaptainlog_CaptainLog.Controls:
if ctrl.Name == "Captain'sLog":
captainloglistbox = ctrl
break

global lastentrydatetime
lastentrydatetime = None


def PCL_Menu_PageActivated( page ):
if page == Pagecaptainlog:
pass


def CheckForSunkShips():
global captainloglistbox

sunkenships = []

try:
# first thing is get all the sunken ships
for ctrl in captainloglistbox.Controls:
if ctrl.Name == "SampleEventView":
for c in ctrl.Controls:
if c.Name == "Listbox with items":
for d in c.Controls:
if d.Name == "text":
numcommas = len( d.Text.split( ',' ) )
if numcommas == 2:
if d.Text.StartsWith( Menu.GetLocalizedText( IDSTR_ShipSunk ) ):
sunkenships.append( c )
break

if len( sunkenships ) == 0:
return

# now reverse the list
sunkenships.reverse()
#ScriptManagerManaged.ShowPythonError( str( sunkenships ) )

global lastentrydatetime
tonnage = None
shiptype = None
latlong = None
datetime = None

for ship in sunkenships:
for d in ship.Controls:
if d.Name == "text":
numcommas = len( d.Text.split( ',' ) )
if numcommas == 2:
if d.Text.StartsWith( Menu.GetLocalizedText( IDSTR_ShipSunk ) ):
commaindex = d.Text.IndexOf( ',' )
tonnage = d.Text[ commaindex + 2 : d.Text.IndexOf( ' ', commaindex + 2 ) ]
shiptypeindex = None
for i in range( commaindex, 0, -1 ):
if d.Text[ i ] == "!":
shiptypeindex = i + 1
break
shiptype = d.Text[ shiptypeindex : commaindex ].Trim()
else:
latlong = d.Text
elif numcommas == 3:
# extract date and time
datetime = DateTime.Parse( d.Text )
datetime = datetime.AddMilliseconds( 1 )

if tonnage != None and shiptype != None and latlong != None and datetime != None:
if lastentrydatetime == None:
lastentrydatetime = datetime
elif datetime < lastentrydatetime:
tonnage = None
shiptype = None
latlong = None
datetime = None
continue
else:
lastentrydatetime = datetime

lom = TDWUtils.ConvertCaptainLogLatAndLongToOriginMeters ( latlong )
txt = shiptype + " " + tonnage + " " + Menu.GetLocalizedText( IDSTR_Tons )
from PageDefaultHud import CreateNewDestroyedMark
CreateNewDestroyedMark( lom.X, lom.Y, txt, True )
msg = Menu.GetLocalizedText( IDSTR_WEPS ) + ": " + shiptype + " " + Menu.GetLocalizedText( IDSTR_SunkAtPosition ) + " " + latlong + ". " + Menu.GetLocalizedText( IDSTR_Tonnage ) + ": " + tonnage + " " + Menu.GetLocalizedText( IDSTR_Tons ) + "."
from PageDefaultHud import Game_NewPlayerLogMessageOutside
Game_NewPlayerLogMessageOutside( [ msg, False ] )
tonnage = None
shiptype = None
latlong = None
datetime = None

lastentrydatetime = lastentrydatetime.AddSeconds( 1 )
except:
pass


# donelooking = False
# tonnage = None
# shiptype = None
# latlong = None
# datetime = None
#
# for ctrl in captainloglistbox.Controls:
# if ctrl.Name == "SampleEventView":
# for c in ctrl.Controls:
# if c.Name == "Listbox with items":
# for d in c.Controls:
# if d.Name == "text":
# numcommas = len( d.Text.split( ',' ) )
# if numcommas == 2:
# if d.Text.StartsWith( IDSTR_ShipSunk ):
# commaindex = d.Text.IndexOf( ',' )
# tonnage = d.Text[ commaindex + 2 : d.Text.IndexOf( ' ', commaindex + 2 ) ]
# shiptypeindex = None
# for i in range( commaindex, 0, -1 ):
# if d.Text[ i ] == "!":
# shiptypeindex = i + 1
# break
# shiptype = d.Text[ shiptypeindex : commaindex ].Trim()
# else:
# latlong = d.Text
# elif numcommas == 3:
# # extract date and time
# datetime = DateTime.Parse( d.Text )
#
# global lastentrydatetime
# if lastentrydatetime == date:
# donelooking = True
# tonnage = None
# shiptype = None
# latlong = None
# datetime = None
#
# if ( ( tonnage != None and shiptype != None and latlong != None and datetime != None ) or donelooking ):
# donelooking = True
# break
#
# if donelooking:
# break
# if donelooking:
# break
#
# if tonnage != None and shiptype != None and latlong != None and datetime != None:
# msg = shiptype + " sunk at position: " + latlong + ". Tonnage " + tonnage + " tons"
# from PageDefaultHud import Game_NewPlayerLogMessageOutside
# Game_NewPlayerLogMessageOutside( [ msg, False ] )


def PCL_Menu_PageDeactivated( page ):
if page == Pagecaptainlog:
pass


def UnloadScript():
Menu.PageActivated -= PCL_Menu_PageActivated
Menu.PageDeactivated -= PCL_Menu_PageDeactivated