[TEC] SH5.exe patches to fix bugs and add functionality

[volodya61]

Originally Posted by Fifi

Depending what you call rough sea...
It happens in all kind of sea here, even calm

OK, then another argument.. in the early WWII magnetic detonators practically/almost didn't work.. this issue was fixed later.. I don't remember the exact dates..

[Macardigan]

Originally Posted by Mysterius

Thank you Volodya, I found the problem .
I activated by accident the fix that removes certain items from the game (don't remember the actual name).

Without it, it works !

Render Patches: Remove certain items from ever being rendered in the game.

I have activated only "change 1, change 2 and change 3" (inside render patches)

* If active any more then I have CTD when I enter the NAVMAP. (map).

I use real_navigation.

[TheDarkWraith]

Originally Posted by Fifi

Patch Fix circle runner chance still giving me many circling torpedos...
Fired 4, 2 were circling!

About destroyed ships falling through the sea floor and disappearing, my last one disappeared before reaching ground. Maybe because it was too deep?

2 were circling out of 4 is perfect If you look at the torpedoes .sim file the circle runner chance is set to 50% for the early years

If it disappeared before reaching ground that means it was >= 500m in depth. I left that part of the code alone since you can't take your sub that deep.

I'll take a look at the code for magnetic detonators again. It's possible I made the same assumption about MSVCR90.rand returning a 32bit number when it actually returns a 16bit number.

[Tonci87]

Originally Posted by TheDarkWraith

2 were circling out of 4 is perfect If you look at the torpedoes .sim file the circle runner chance is set to 50% for the early years

If it disappeared before reaching ground that means it was >= 500m in depth. I left that part of the code alone since you can't take your sub that deep.

I'll take a look at the code for magnetic detonators again. It's possible I made the same assumption about MSVCR90.rand returning a 32bit number when it actually returns a 16bit number.

Oh so you get more reliable torps as the war advances? That is cool.

[TheDarkWraith]

Looking over the magnetic detonators again. I did make the same assumption about MSVCR90.rand returning 32bit number instead of 16bit number. I'm revising the code.

Another interesting thing has shown itself while looking over the code for magnetic detonators. Did you know that the torpedo could detonate upon firing if the magnetic detonator is active and the wave height is within the parameters of the premature chances defined in the torpedoes .sim file? I see the code for it but the devs 'dumbed it down' so it RARELY ever happens. Time to fix this This will make you think twice about switching to magnetic detonators with large wave heights

[gap]

Originally Posted by TheDarkWraith

Another interesting thing has shown itself while looking over the code for magnetic detonators. Did you know that the torpedo could detonate upon firing if the magnetic detonator is active and the wave height is within the parameters of the premature chances defined in the torpedoes .sim file? I see the code for it but the devs 'dumbed it down' so it RARELY ever happens. Time to fix this This will make you think twice about switching to magnetic detonators with large wave heights

maybe give it an higher chance... but not 100%

P.S: any news on the RPM/boat's speed curve, and about separate speed ratios for diesel/electric propulsions?

http://www.subsim.com/radioroom/show...postcount=1683

[volodya61]

Originally Posted by Macardigan

I have activated only "change 1, change 2 and change 3" (inside render patches)
* If active any more then I have CTD when I enter the NAVMAP. (map).
I use real_navigation.

In my experience - render patches: 1, 2, 3, 8, 9 are always enabled.. never had CTD's when testing other Сhanges in campaign mode..
Perhaps you should start a new campaign after enabling other changes..
Perhaps you can't using other Changes enabled and Real Navigation together..

[volodya61]

Patch AI units falling through seafloor test report

1. Scapa Raid

Two hours after sank -

. . .

. . .

. . .

.

Last screen shows the severed stern of the ship that sank three kilometers from here..

To be continued

[volodya61]

Ten hours after sank -

. . .

.

After ten hours some ships have disappeared.. some migrated.. some I wasn't able to find the post-migration..

2. The patch also has a negative effect on the subnets -

the patch is enabled

.

the patch is disabled

.

At the moment I don't see sense to enable the patch because some ships in ten hours migrated from a place of sinking farther than 5-6 km.. how far are they able to migrate in a week?

Requires further improvements

PS: revised circle runner patch will be tested later

[TheDarkWraith]

Originally Posted by gap

maybe give it an higher chance... but not 100%

Actually I'm trying to fix a problem that doesn't really exist. The problem is the data entered in the torpedoe's .sim file If you look at the notes at the bottom for each entry some will say percentage but the value for it is a whole number Whoever made the .sim file for the torpedoes didn't know what they were doing A percentage is a value from 0.0 to 1.0. Some of the failure 'percentages' are 50 for example when they should be 0.5 What a freakin mess

[TheDarkWraith]

Originally Posted by volodya61

At the moment I don't see sense to enable the patch because some ships in ten hours migrated from a place of sinking farther than 5-6 km.. how far are they able to migrate in a week?

Requires further improvements

I said it wasn't perfect yet. If the sea floor is not level when the unit contacts it then the unit will 'walk' on the sea floor until it enters into a valley or ends up on level ground.

I can fix the problem with the subnets and the patch. I just have to check the unit's type first to see if the patch applies to it or not

[gap]

@ Volodya

Man, I will sponsor you for the "Beta Tester of the Century" Subsim Award, if ever they will introduce such a contest

[gap]

Originally Posted by TheDarkWraith

Actually I'm trying to fix a problem that doesn't really exist. The problem is the data entered in the torpedoe's .sim file If you look at the notes at the bottom for each entry some will say percentage but the value for it is a whole number Whoever made the .sim file for the torpedoes didn't know what they were doing A percentage is a value from 0.0 to 1.0. Some of the failure 'percentages' are 50 for example when they should be 0.5 What a freakin mess

Yes, Rongel had told me something about those discrepancies, when he worked on his Torpedo Failures Patch.

Originally Posted by TheDarkWraith

I said it wasn't perfect yet. If the sea floor is not level when the unit contacts it then the unit will 'walk' on the sea floor until it enters into a valley or ends up on level ground.

Apparently friction is not simulated in game

Originally Posted by TheDarkWraith

I can fix the problem with the subnets and the patch. I just have to check the unit's type first to see if the patch applies to it or not

Brilliant

[Tonci87]

Originally Posted by TheDarkWraith

Looking over the magnetic detonators again. I did make the same assumption about MSVCR90.rand returning 32bit number instead of 16bit number. I'm revising the code.

Another interesting thing has shown itself while looking over the code for magnetic detonators. Did you know that the torpedo could detonate upon firing if the magnetic detonator is active and the wave height is within the parameters of the premature chances defined in the torpedoes .sim file? I see the code for it but the devs 'dumbed it down' so it RARELY ever happens. Time to fix this This will make you think twice about switching to magnetic detonators with large wave heights

Oh ****....

Just out of interest, how deep should the torp run to prevent beeing triggered by the waves?

[Scümbagfuhrer]

Hello, since my steam version of the game doesn't accept this patcher, what if I used the downloaded uplay version of this game, is it same with the retail version? so this patcher will work correctly?