Torpedo Auto-Reload Mod

[reaper7]

http://www.subsim.com/radioroom/picture.php?albumid=236&pictureid=5075

V1.0
Mod that configures the Torpedo Auto-Reload function within Sh3 to be Turned Off initially.

Mod contains just one file: AutoReload SH3.exe

This file can be run from any location. On starting the file - it will automatically start Silent Hunter 3.
Once the Game has loaded and started it will Turn the Auto-Reload to off.
Then the file will terminate leaving SH3 running.

Auto-reload can be turned back on by bringing up the Torpedo Panel - default is the 'i' key. And turning the checkbox to on.

V1.1
Changes

Added in code to 3rd Variable (CheckBox Ticked)
Changed Original Pointers to New pointers that worked across both my PC's and with GWX
Added larger delay before code is executed to allow run on slower laptops etc


V1.1 Standard Edition - Download:
http://www.subsim.com/radioroom/downloads.php?do=file&id=3419

V1.1 SH3Commander Edition - Download:
http://www.subsim.com/radioroom/downloads.php?do=file&id=3420



Ok, this was more difficult than expected, but I belive I have it working correctly now. I've tested it as much as possible - but due to the way the variables are used for this within sh3 its Impossible to say if it will work 100% of the time for everybody.
I think I've coded it so no matter what the Memory address its reading from it can tell the correct value required to run the code.
But best ye test it and let me know if it works ok for you. :salute:

[Fish In The Water]

First off, let me just say thank you for the time and effort to put this together. For those of those who like to have different torpedo types loaded in different tubes, this is a great relief.

I suppose it may be difficult to understand if you haven't been there yourself, but having your loadout messed up for the umpteenth time can become quite annoying. For me, it's very much akin to having to manually load the first deck gun shell in GWX. Where's the crew? And why are they waiting for me to hold their hand?

Any Weps officer serving on my crew would know I prefer type I's in tubes one and two and wouldn't go jamming a type II in there just because I didn't remind him for the millionth time.

As a result, this is a very welcome addition to the SH3 world. I'm downloading as we speak and will begin testing later today.

One quick question regarding SH3 Commander. Would it be possible to setup a three way chain so that Commander calls 'AutoReload SH3.exe' which in turn calls sh3.exe? I realize some editing and/or file renaming would be involved, but I'm just wondering if it would work in theory?

I'll be looking into this as well, but in any event, I really want to thank you once again for the release and especially for all the help you've provided. :yeah:

[Madox58]

Great work to all involved.
:yeah:

[Fish In The Water]

Great work to all involved.
:yeah:

And that certainly includes you my friend. Dare I say without you raising the issue, (and in effect 'championing' the cause), we would never have gotten this far. Much gratitude and respect! :salute:

[frau kaleun]

For me, it's very much akin to having to manually load the first deck gun shell in GWX. Where's the crew? And why are they waiting for me to hold their hand?

Just edit the appropriate part(s) of the basic.cfg so that the game gives you 1 round of AP ammo instead of 0, and 1 less round of HE ammo than what is currently indicated, for both types of deck gun. Total amount of ammo remains the same, but when you order the deck gun manned the crew will auto-load that one round of AP ammo because they're hardcoded to load AP ammo first (thus the problem when there's no AP ammo available). After that they'll continue loading the gun with the remaining HE ammo until ordered to stand down. Problem solved!

As far as I can tell it works, because when I put men on the gun and order "Feuer Frei" they just load up and start shooting all on their own. I know GWX took out the AP ammo for purposes of historical accuracy and realism, but I figure the first shot never hits the target anyway, so having that 1 AP round in there hardly counts as an unrealistic advantage. :haha:

[reaper7]

One quick question regarding SH3 Commander. Would it be possible to setup a three way chain so that Commander calls 'AutoReload SH3.exe' which in turn calls sh3.exe? I realize some editing and/or file renaming would be involved, but I'm just wondering if it would work in theory?

Thanks Mate, One method would be to launch Sh3 via Commander, then alt-tab out and start this mod. :up:
Hope it works ok now :D

Great work to all involved.
:yeah:

Thank you Mate, all long as you get some use out of it then it was worthwhile :up:

[Fish In The Water]

Just edit the appropriate part(s) of the basic.cfg so that the game gives you 1 round of AP ammo instead of 0, and 1 less round of HE ammo than what is currently indicated, for both types of deck gun. Total amount of ammo remains the same, but when you order the deck gun manned the crew will auto-load that one round of AP ammo because they're hardcoded to load AP ammo first (thus the problem when there's no AP ammo available). After that they'll continue loading the gun with the remaining HE ammo until ordered to stand down. Problem solved!

Good idea. Thank you, I'll be sure and give this a try! :up:

[Fish In The Water]

Thanks Mate, One method would be to launch Sh3 via Commander, then alt-tab out and start this mod. :up:
Hope it works ok now :D

Sounds good, will give it a go and thanks again! :yep:

*******

Just finished my first test with some rather unexpected results. Everything loaded up fine, 'Auto Reload' was deselected and yet when I fired off my first eel the crew proceeded to reload without taking the new eel out of inventory.

In other words, the auto function is still active plus I appear to have an infinite supply of torpedoes on board. This got me thinking as to possibles causes, and the only thing I've been able to come up with so far (as possibly having an effect), is the fact I'm running a modded basic.cfg which adds extra inventory beyond the usual load.

I'll try swapping it out for a default config file and see if it makes a difference. :hmmm:

[makman94]

John, i don't understand what was the issue that this mod is fixing.
is it all about the default setting at auto-reload torpedo order for the crew ? and if yes...what was the issue ?
(my crew always were uploading the tubes...didn't need to do anything)

[frau kaleun]

John, i don't understand what was the issue that this mod is fixing.
is it all about the default setting at auto-reload torpedo order for the crew ? and if yes...what was the issue ?
(my crew always were uploading the tubes...didn't need to do anything)

IIRC someone asked if there was a way to have auto-reload set to "off" by default when the game starts, instead of on until you turn it off manually.

[SquareSteelBar]

Doesn't work for me.

Auto reload is still switched on at game start.

sh3.exe currently patched to h.sie's V15G2...

[reaper7]

Hmmm, maybe the variable changes from that used in stock with mods applied.
I'll try activating some mode to see if that breaks the memory location.
If there thats the case will have to see if there is a different workaround to having it set off as default :hmmm:.


John, i don't understand what was the issue that this mod is fixing.
is it all about the default setting at auto-reload torpedo order for the crew ? and if yes...what was the issue ?
(my crew always were uploading the tubes...didn't need to do anything)

Hi Mate, what this mod does is switches the Auto-reload from On to Off on starting of game.
This was requested in Stieblers thread to prevent Torpedoes being auto loaded so the User can select the correct torpedo for different tubes.
Without the need for the player to remember to goto torpedo screen and uncheck the tickbox selection.
A small mod but has its place :Kaleun_Los:

[SquareSteelBar]

Just tried the unpatched exe - no luck

[reaper7]

My mistake:

Oooops my bad!!!!

Just tried the file I uploaded and it didn't work - so looked into it and its not the correct version - I appear to have compiled an older non-functional version :oops:.

Sorry Guys I'll reupload the correct one ASAP :up:


EDIT: File is re-uploaded
http://www.subsim.com/radioroom/downloads.php?do=file&id=3419

[SquareSteelBar]

Still doesn't work neither with patched exe nor with unpatched.

[reaper7]

Still doesn't work neither with patched exe nor with unpatched.

When you open the Torpedo - Relaod Page (Default Key 'i') is the Checkbox ticked or unticked.
Also in the Taskbar can you see the App AutoReload.exe (Hover Mouse over it - does it remain or disappear) after you enter the mission.?

Are you running stock - I've only tested this with stock. Have yet to install any SuperMods (None are install due to current Mod work).
Will try to get another SH3 Installation up and running to test with Mods, see if there is a variable difference :hmmm:.

Anyone having any luck getting this up and running, works perfect this end for me even after PC reset.


EDIT: Tested with H.Sie latest Realism and gameplay related hardcode fixes V16A3,and works ok (Again with Stock)

[Fish In The Water]

sh3.exe currently patched to h.sie's V15G2...

I ran another set of tests with the default configuration but the results were exactly the same. With the first suspect eliminated I'm now thinking about the .exe version. (I'm also running h.sie's patch V15G2).

Will try the corrected version you just posted, and hopefully it's not GWX that's affecting the memory location. Thanks for the new up! :up:

[reaper7]

I ran another set of tests with the default configuration but the results were exactly the same. With the first suspect eliminated I'm now thinking about the .exe version. (I'm also running h.sie's patch V15G2).

Will try the corrected version you just posted, and hopefully it's not GWX that's affecting the memory location. Thanks for the new up! :up:

Hi Mate, first version I posted was the wrong file - that one would never have worked - My mistake (was an older WIP file and not the finished file).
The re-uploaded file was the one I should have posted orginally :up:

[SquareSteelBar]

Hi Mate, first version I posted was the wrong file...Why don't you edit your first post?

When you open the Torpedo - Relaod Page (Default Key 'i') is the Checkbox ticked or unticked.
Also in the Taskbar can you see the App AutoReload.exe (Hover Mouse over it - does it remain or disappear) after you enter the mission.?

Are you running stock - I've only tested this with stock...


- WinXP Home SP3
- checkbox remains ticked
- AutoReload.exe dissappears when hovering cursor
- stock
- sh3.exe [MD5 = 510b271d14621361386197be6bd8cc0c]

[PapaKilo]

Why to release the mod seperatly ? If it's possible to add this feature to optionselection menu, then H.sie should do it, this mod is required with semi-docking with U-tankers. If I understood the readme correctly those few torps are to be installed right into torpedo tubes, so they should be empty by that time, and it is impossible to unload the tube, since auto-reload is on by default.

[Fish In The Water]

Hi Mate, first version I posted was the wrong file - that one would never have worked - My mistake (was an older WIP file and not the finished file).
The re-uploaded file was the one I should have posted orginally :up:

Third test complete and I'm happy to report the new file worked like a charm! Many thanks for the time and effort John, it truly is appreciated!! :yeah:

That being said, I'm still looking at the issue of how to best integrate this with Commander. I tried a simple Alt-Tab, only to have the game hang, which in my case is something that almost never happens. Hence my question, would it be possible to make a version that calls Commander and if so, would the memory fix still remain resident?

Any help or further suggestions you could provide in this regard would be greatly appreciated! :yep:

Why to release the mod seperatly ? If it's possible to add this feature to optionselection menu, then H.sie should do it, this mod is required with semi-docking with U-tankers. If I understood the readme correctly those few torps are to be installed right into torpedo tubes, so they should be empty by that time, and it is impossible to unload the tube, since auto-reload is on by default.

We explored that route initially but were unsuccessful in bringing it to fruition. Please see the following thread (starting at post 26) for details:

http://www.subsim.com/radioroom/showthread.php?t=186354

[Fish In The Water]

Just edit the appropriate part(s) of the basic.cfg so that the game gives you 1 round of AP ammo instead of 0, and 1 less round of HE ammo than what is currently indicated, for both types of deck gun. Total amount of ammo remains the same, but when you order the deck gun manned the crew will auto-load that one round of AP ammo because they're hardcoded to load AP ammo first (thus the problem when there's no AP ammo available). After that they'll continue loading the gun with the remaining HE ammo until ordered to stand down. Problem solved!

Just wanted to say thanks again and also let you know it worked out just like you said. :salute:

The only thing is, being the nitpicky/obsessive type :03:, it was really bothering me that the deck gun menu and texture display were still showing 'HE' even though my crew had already auto loaded the lone AP shell. This was something that just had to be fixed.

As a result, I cruised on over to the menu_1024_768.ini file and took out all those pesky little semicolons the GWX folks inserted to suppress my AP texture and tool tip. Now when my lone AP shell is auto loaded the screen actually shows an AP shell as opposed to remaining on HE in perpetuity. In other words, all is once again well in my little world. :O:

Cheers for the idea. As my lone AP careens into some poor unsuspecting ship, I shall remember you fondly. Or something to that effect. :haha:

[frau kaleun]

Cheers for the idea. As my lone AP careens into some poor unsuspecting ship, I shall remember you fondly. Or something to that effect. :haha:

:O:

Glad it works for you. :yeah:

Could you point me to the section in the menu .ini where you made the adjustment to show the AP ammo in the game? I started looking for it when I first enabled the fix but at the time I'd never tinkered with that file before so it was a bit daunting. Then I got sidetracked with something else and sort of forgot about it. :hmmm:

[Fish In The Water]

Could you point me to the section in the menu .ini where you made the adjustment to show the AP ammo in the game?

Absolutely, be happy to...

Simply Ctrl-F down to section '[G38 I8]' and '[G38 I9]'. Once there you'll need to remove all the semi-colons except for the ones that occur in the two 'type' lines, (i.e. Type=1029;Static text). There's a line like this (starting with Type=) in each of the two sections.

Also leave the semi-colon in the 'Display=2;Linear' line from section 2. Other than that, they all come out. Once that's done, the AP display should be back in business. Enjoy! :sunny:

[frau kaleun]

Danke, mein Herr!

[Fish In The Water]

Danke, mein Herr!

You're most welcome! :sunny:

[reaper7]

Third test complete and I'm happy to report the new file worked like a charm! Many thanks for the time and effort John, it truly is appreciated!! :yeah:

That being said, I'm still looking at the issue of how to best integrate this with Commander. I tried a simple Alt-Tab, only to have the game hang, which in my case is something that almost never happens. Hence my question, would it be possible to make a version that calls Commander and if so, would the memory fix still remain resident?

Any help or further suggestions you could provide in this regard would be greatly appreciated! :yep:

- WinXP Home SP3
- checkbox remains ticked
- AutoReload.exe dissappears when hovering cursor
- stock
- sh3.exe [MD5 = 510b271d14621361386197be6bd8cc0c]

Thats great Fish In The Water, was starting to think this was only going to work on my machine - that confirms its the correct variable I'm reading and adjusting. Just need to figure out why its not working for SquareSteelBar :hmmm:

As for loading sequence, I can make one that autoloads Sh3 Commander instead of Sh3 or I can make it not load anything so can be manually started before either application.
Any preference :D

@SquareSteelBar: Another question, are you using Starforce enabled Sh3 or Steam Downloaded version - that may be the cause of the problem.
I have no way to test if they use the same memory location myself. :damn:

[Fish In The Water]

As for loading sequence, I can make one that autoloads Sh3 Commander instead of Sh3 or I can make it not load anything so can be manually started before either application.
Any preference :D

That sounds great, wonderful news! :yep:

I'm thinking Commander might be the best way to go as that way it's just a single click. Not that it would be a big deal to load it manually as I already do that with Game Booster and I never have an issue with pre-game forgetfulness.

So I guess Commander would be my first choice, unless you happen to run into a memory issue, in which case manual is fine. :sunny:

[SquareSteelBar]

It's the non-starforced EMEA DVD 1.4b exe

[reaper7]

That sounds great, wonderful news! :yep:

I'm thinking Commander might be the best way to go as that way it's just a single click. Not that it would be a big deal to load it manually as I already do that with Game Booster and I never have an issue with pre-game forgetfulness.

So I guess Commander would be my first choice, unless you happen to run into a memory issue, in which case manual is fine. :sunny:

Ok will make another version that load Sh3Commander on activation. :up:

It's the non-starforced EMEA DVD 1.4b exe

Hmmm, that should be identical to my own - :06:
So what is causing the issue for you, I'll try to getGWX installed and test to see if that's an Issue :hmmm:
I'll also post a version that displays the Memory Variable to see if its reading /writing the value to the location.

[SquareSteelBar]

http://www.amazon.de/Purple-Hills-Silent-Hunter-3/dp/B002YNS4FY

sh3.exe -> MD5 = 510b271d14621361386197be6bd8cc0c

[reaper7]

Added Sh3Commander Edition to 1st Post

Download
http://www.subsim.com/radioroom/downloads.php?do=file&id=3420

[reaper7]

http://www.amazon.de/Purple-Hills-Silent-Hunter-3/dp/B002YNS4FY

sh3.exe -> MD5 = 510b271d14621361386197be6bd8cc0c


hi Mate, uploaded a debug Edition to see if the Variables are being read/written to.
http://www.subsim.com/radioroom/downloads.php?do=file&id=3421

Can you run Sh3 in windowed mode and start it via this app.
A window will pop up with the current variable being read. Start a Mission and note the values as the mission starts click ok and repeat.
If all goes well and it works correctly there will be 6 dialogue boxed in total.
If you just keep getting the same 2 then its not reading correctly and hopefully the 2nd one will shed some light into the Issue :up:

[SquareSteelBar]

Don't know if I got you right.

Is this what you want?

http://www7.pic-upload.de/04.11.11/v7xj4rasktgw.jpg

[reaper7]

Don't know if I got you right.

Is this what you want?

http://www7.pic-upload.de/04.11.11/v7xj4rasktgw.jpg

Hi Mate Yes, there should be between 2 to 6 of those depending on working/not working.

Integer", "Initial Reload Code Value
Hex to 3 places", "Initial Reload Code Value:
Integer", "Hex to 3 places
Hex to 3 places", "Reload Code Seting to Off:
Integer", "Checkbox Code Setting to Off:
Hex to 3 places", "Checkbox Code Setting to Off:


Only the first 2 will show if not working and will repeat.

My code looks for 001 before going into the Switch Reload off code.

The pic you poted shows the Hex value is 9A800000 so its setting is 000

Does the above value stay the same in Campaign/single mission/Naval Accademy missions.
Also if you keep hitting ok for the values does it stay the same when switching between Auto reload on/off manually?
Also if you load sh3 from scratch do you still have the same value as above - if so I could code this on in too so it checks for both values (That is if that variable is related to the AutoRelad at all).

[Fish In The Water]

Sorry to say I may have spoken too soon. I did get an initial test that succeeded, but since then it's failed on two different occasions. :hmmm:

Just heading out, so I'll have to look at it again later.

[reaper7]

I'm beginning to think this is going to only work on my PC.

Tried my laptop with GWX and didn't work. Then tried Stock on my Laptop and it 1/2 worked (Auto-reload was off but tickbox was still ticked).

Seems like the memory location is not fixed per PC - very strange this Issue.
Not sure where to go from here.
May have to give up also on this one. :damn:

Sorry to say I may have spoken too soon. I did get an initial test that succeeded, but since then it's failed on two different occasions. :hmmm:

Just heading out, so I'll have to look at it again later.

Oh one thing I forgot to mention, this will only work first time its ran. So if you quit or die from a mission the file needs to be run again before starting a new mission.

[Madox58]

The tick box can removed if the time is right.
It's a hard coded menu item for one.
And there are 2 references to that menu item in the SH3.exe
One is used to call the Menu item.
The other is used to pass values.

[SquareSteelBar]

Sorry for the late reply...

...Auto-reload was off but tickbox was still ticked...Now I understand.
The only thing I always checked on game start was the tickbox by hitting 'I' key, didn't check the AutoReload function itself - sorry for the misdirection...

Checked it again: 'AutoRelod off' is working on game start though the tickbox is in 'on' state... :salute:

[Fish In The Water]

The only thing I always checked on game start was the tickbox by hitting 'I' key, didn't check the AutoReload function itself - sorry for the misdirection...

Same here on the two fails. I didn't go further because the menu box was deselected the first time when the function worked correctly. Will try again and simply ignore the menu. :yep:

[reaper7]

The tick box can removed if the time is right.
It's a hard coded menu item for one.
And there are 2 references to that menu item in the SH3.exe
One is used to call the Menu item.
The other is used to pass values.

Hi Mate, I have found 3 items relating to that value the two you mention above (which control the TickBox and do not effect Autoreload directly) and a third value that defines if AutoReload is on or off.
As for timing I have that working ok too. Main-code loop is not entered until SH3 starts in game and Autoreload Address is written to. Then it pauses a second to make sure the other 2 address are updated and can be read/written too.
Problem I think may be the Memory Address for the checkbox due to sh3sim.act as stated below ???

Sorry for the late reply...

Now I understand.
The only thing I always checked on game start was the tickbox by hitting 'I' key, didn't check the AutoReload function itself - sorry for the misdirection...

Checked it again: 'AutoRelod off' is working on game start though the tickbox is in 'on' state... :salute:

Same here on the two fails. I didn't go further because the menu box was deselected the first time when the function worked correctly. Will try again and simply ignore the menu. :yep:

:yeah: yes that means the critical Value for AutoReload is correctly working. The checkbox code is called by the SH3Sim.act file and may be causing different memory locations than my PC (This location is always the same on my PC even after PC reboot).
I will search this value of a few different PC's to see what locations they are assigning - hopefully I can figure out some method to lock it down :hmmm:

[Fish In The Water]

:yeah: yes that means the critical Value for AutoReload is correctly working.

Yes! :yeah: I just ran a couple more tests and the 'critical value' is working fine. The menu box is ticked but no auto reload actually takes place. :woot:

I think what threw me is that somewhere between the first and third tests the menu box became active again as it was definitely blank the first time. If you can nail it down great, but if not, no big deal as the main function is working and that's what really matters.

Also wanted to add a thank you for the quick response with the Commander version. Really appreciate the effort as I'm definitely looking forward to not having to manually configure this anymore. Thanks very much and a big thumbs up! :up:

[reaper7]

Yes! :yeah: I just ran a couple more tests and the 'critical value' is working fine. The menu box is ticked but no auto reload actually takes place. :woot:

I think what threw me is that somewhere between the first and third tests the menu box became active again as it was definitely blank the first time. If you can nail it down great, but if not, no big deal as the main function is working and that's what really matters.

Also wanted to add a thank you for the quick response with the Commander version. Really appreciate the effort as I'm definitely looking forward to not having to manually configure this anymore. Thanks very much and a big thumbs up! :up:


Thats great so confirmed working in principle :up:. Hope I can figure out the checkbox to have it 100% :salute:.

No problem with the Sh3Commander version - Just Glad it worked.
Couldn't find a registry entry for its Installed path - so had to use one for its uninstall path (Tells my App where to find the exe for Sh3 Commander), so wasn't 100% sure it would work :D.

[reaper7]

V1.1 Released

Changes

Added in code to 3rd Variable (CheckBox Ticked)


Changed Original Pointers to New pointers that worked across both my PC's and with GWX


Added larger delay before code is executed to allow run on slower laptops etc.


Hopefully this should solve the Tickbox still being ticked even though Autoreload is deactivated. :up:

Downloads in first Post

[Fish In The Water]

V1.1 Released

Thanks for 1.1! :up:

Downloading now to test... :yep:

[Fish In The Water]

Good news. 1.1 is working! :woot:

No auto reload and no tick in the box. Nice job! :yeah:

Just wondering, which registry entry did you use for the Commander version? Could you possibly post or send me the path? Also, would it be possible to compile the fix so that it looks for the Commander .exe in the active folder?

The reason I ask is I did something a little unconventional with mine a while back and I'm thinking it would be easier to edit the registry rather than reinstall. Then again, if it could be set to check the active folder I wouldn't have to do either. Thanks again for all the help and apologies for the little quirks along the way. :03: :D

[reaper7]

Good news. 1.1 is working! :woot:

No auto reload and no tick in the box. Nice job! :yeah:

Just wondering, which registry entry did you use for the Commander version? Could you possibly post or send me the path? Also, would it be possible to compile the fix so that it looks for the Commander .exe in the active folder?

The reason I ask is I did something a little unconventional with mine a while back and I'm thinking it would be easier to edit the registry rather than reinstall. Then again, if it could be set to check the active folder I wouldn't have to do either. Thanks again for all the help and apologies for the little quirks along the way. :03: :D

Excellent, hope this is the same story for all Mods and PC's - would be great to have the correct variable locked down for all situations (Well its looking good :DL).

The Registry entry is "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Curr entVersion\Uninstall\SH3 Commander_is1", "InstallLocation" where InstallLocation holds the directory the Sh3Commander.exe is installed too. :up:

The above Registry Address should be sufficient for my App as it contains the Directory that Sh3Commander is Installed to anyway as it has to Un-Install from the same location :D.
And it works - so should work for everyone. I could use the Ubisoft one "HKEY_LOCAL_MACHINE\SOFTWARE\Ubisoft\Silent Hunter III", "InstalledPath" and amend the Sh3Commander Directory to it but the result at the end of the day would be the same. :up:

Glad it works :up:

[Fish In The Water]

The Registry entry is "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Curr entVersion\Uninstall\SH3 Commander_is1", "InstallLocation" where InstallLocation holds the directory the Sh3Commander.exe is installed too. :up:

Added the key and Commander fired right up! :yeah:

Thanks again for taking on this project and especially for seeing it through to completion. Much respect and appreciation! :salute:

[reaper7]

Your welcome mate :up: