Thread: [REL] patSH3r - Reborn
View Single Post
Old 06-03-19, 05:19 PM   #221
areo16
Sonar Guy
 
Join Date: Oct 2013
Posts: 377
Downloads: 64
Uploads: 0
Default

Quote:
Originally Posted by Fader_Berg View Post
If I make one patch I might end up having to write two or more patches to make it compatible with hsies. One when hsie.A i enabled. One more when hsie.A is disabled. Fu*k... it crashes. This because a variable in the hsie.A-code are also being used in hsie.C and -F-code too, and doesn't get updated correctly now. I have to figure out how this variable works in fragmented, disorganized and very sparse commented code in gerrman. By the way... which other hsie-features uses this variable also?! Not to mention all variables that are being used between A, B, G and O that I may have missed, and doesn't result in a crash. That's gonna affect the game somehow. It probably ends up in some "when I got 56% oxy left and the clock is 12:42 a friday the submarine crashdives"-bug.
I just puked in my mouth.

This sounds like is using global variables here when he should be using local variables? Or he is referencing the same variable from the same package over and over again?


This is a design issue.


What about copying these globals to local variables in the scope you need to use it in, and edit them as such, not affect the global variable itself (assuming you don't need the edits on these variables to be outside of your current scope)?
areo16 is offline   Reply With Quote