Actually smoking in WW2 American subs all depended on your CO and XO. Many (most) were ok with smoking even when submerged. Of course after awhile it was impossible to light a match due to lack of oxygen.
http://www.ussflierproject.com/tags/...on-submarines/
I vaguely remember reading about Dick O'Kane and how the coolest CO's at the periscope would nonchalantly smoke a cigarette to make the crew (who couldnt see the destroyers bearing down) believe everything was ok and normal....