Well you gotta get within a couple thousand yards.
Find the ship you are supposed to photo and lock the periscope on it.
In the peri menu bar there is an icon to take the picture, it should light up.
You may have to take photos of several different ships.
DON,T SINK THE SHIPS TILL AFTER YOU HAVE THE PHOTOS.
I did this once and could never complete the mission.
Magic