SUBSIM Radio Room Forums



SUBSIM: The Web's #1 resource for all submarine & naval simulations since 1997

Go Back   SUBSIM Radio Room Forums > Silent Hunter 3 - 4 - 5 > Silent Hunter 4: Wolves of the Pacific
Forget password? Reset here

Reply
 
Thread Tools Display Modes
Old 01-31-18, 08:56 PM   #1
Ichthyos
Seaman
 
Join Date: Jan 2018
Posts: 38
Downloads: 4
Uploads: 0
Default error in sub UPC files: no definitions for deck watch compartment

I just noticed that all the US subs are missing a definition in their .UPC files for the "Deck Watch" compartment.

it's even kinda hinted at in the notes near the top of each file:

;------------------------------------------------------------
; COMPARTMENTS STRUCTURE
;------------------------------------------------------------


; Compartments Functional Types
;
; FunctionalType= BowTorpedoRoom
; FunctionalType= SternTorpedoRoom
; FunctionalType= PropulsionRoom
; FunctionalType= SensorsRoom
; FunctionalType= CommandRoom
; FunctionalType= DamageControlRoom
; FunctionalType= ObservationRoom - Do we need this separate from SensorsRoom?
; FunctionalType= ArtilleryRoom
; FunctionalType= FlakRoom

it's the observationRoom. to answer a long gone and buried developer question... YES, you needed that separate from the SensorsRoom.

evidently nobody ever answered them, so they just left that out of the definition file.

look for yourself. Pick a sub and open the .upc file associated with it. You will find there is no room other than the command room that is defined to have 3 leaders and 9 crew. Nor are there any definitions for crewmember slots for the observationroom (deck watch).

so... how does it even work? is there some default template somewhere it falls back on? and what values is it using? I gather it likely uses watch statistic at a high level. since the dev asked if they needed it separate from the sensor room, I'd wager it ended up using the same values as those for the sensor room (electrics 0.5, watch 0.5) but who knows?

I can't be the only one who noticed this?
Ichthyos is offline   Reply With Quote
Old 01-31-18, 09:36 PM   #2
Ichthyos
Seaman
 
Join Date: Jan 2018
Posts: 38
Downloads: 4
Uploads: 0
Default

ah, I see, it defaults to a different file in the \Data\UPCData\UPCUnitsData directory.

there is one for each sub that DOES include the info for the deck observation compartment.

weird.
Ichthyos is offline   Reply With Quote
Old 02-01-18, 12:41 AM   #3
Sniper297
The Old Man
 
Join Date: Dec 2005
Location: Philadelphia Shipyard Brig
Posts: 1,386
Downloads: 160
Uploads: 19
Default

As you delve into this you'll find that many files are not used at all, and some entries in other files don't do anything (NSS_Gato.cfg for example, max speed is ignored and taken from the SIM file instead). My theory is they were working on an update for SH3 and decided to add US boats and the Pacific war, then rename it SH4.

Also, in case you're not aware, the semicolon ( ";" at the beginning of the line means "comment, program ignore this line" so

; FunctionalType= ObservationRoom - Do we need this separate from SensorsRoom?

The program sees the ; and skips to the next line - everything you copied and posted is a comment, not a program instruction.
Sniper297 is offline   Reply With Quote
Old 02-01-18, 12:53 AM   #4
Ichthyos
Seaman
 
Join Date: Jan 2018
Posts: 38
Downloads: 4
Uploads: 0
Default

yeah, I knew that was a comment line. that's why I commented on it.

Ichthyos is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 10:36 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright © 1995- 2024 Subsim®
"Subsim" is a registered trademark, all rights reserved.