SUBSIM Radio Room Forums

SUBSIM Radio Room Forums (https://www.subsim.com/radioroom/index.php)
-   SH5 Mods Workshop (https://www.subsim.com/radioroom/forumdisplay.php?f=249)
-   -   [TEC] Journal entries - wrong time? (https://www.subsim.com/radioroom/showthread.php?t=239991)

kapuhy 02-17-19 06:53 AM

Journal entries - wrong time? (solved)
 
I've noticed that when adding new entry in Ship's Journal the displayed time is 1 hour later than it should be. This only happens with my manual entries, not the ones automatically copied from message box. How do I make the time display correctly?

-----------

Ashikaga 02-17-19 08:27 AM

Time display is correct.

There is a difference between Nautical time and Time on your boat *German time*

You can set it so Nautical time is the same as the time in your boat though so everything is the same but that is not really realistic or accurate.


.

kapuhy 02-17-19 02:03 PM

Quote:

Originally Posted by Ashikaga (Post 2592192)
Time display is correct.

There is a difference between Nautical time and Time on your boat *German time*

You can set it so Nautical time is the same as the time in your boat though so everything is the same but that is not really realistic or accurate.


.

I'm afraid I don't quite understand. For example, my boat is near Memel. It is 9:13 GMT, which is 10:13 Nautical Time, and I can switch between any of those times being used in Message Box (and Ship's Journal, as far as entries from Message Box are concerned). Yet when I put an entry in journal manually, it is logged with time GMT + 2 (11:13), leading to my journal looking like this:

https://i.imgur.com/MbgEB0E.jpg

So "German Time" in this case would be GMT + 2 ? And if this is the time used on my boat, why would it be used only for manual journal entries?

Ashikaga 02-17-19 03:55 PM

Ah I see what you mean now.

Hahaha never realized it. Time in boat is 12:55, log entry I just made is 11.55 but my clock is at 13:55 now. Am near Ireland on lat 55,36N long 11,12W.

So not sure why my clock gives time as 13:55...

kapuhy 02-18-19 04:44 AM

Update:

I've tested this in single mission in different time zone (River Mayhem):

GMT: 05:30
Nautical Time: 00:30
Manual entry I've put in ship's log appeared with time 19:30 on a previous day.

So, it would seem that difference between Nautical (local) time and GMT is applied twice to manual log entries.

Ashikaga 02-18-19 04:23 PM

Probably a glitch then. But do you read your logs outside of the game?

kapuhy 02-19-19 02:37 AM

Quote:

Originally Posted by Ashikaga (Post 2592479)
Probably a glitch then. But do you read your logs outside of the game?

Only in game. I was unaware it's possible to view logs outside.

kapuhy 03-10-19 08:43 AM

I think I found a cause for this.

data/scripts/menu/Page Ships Journal.py

There's a fragment:

 
def AddingAccept_Clicked( sender ):
journal = GetShipsJournal()
global EditingBox
entrytext = EditingBox.Text
entrytext = entrytext.PadLeft( 1 )
index = PageShipsJournal_Adding_Title[ "Index" ]
newentry = []

gdt = Game.CurrentGameDateTime
gdt = gdt.AddSeconds( GetTimeZoneModifier() )


After deleting the line in bold, when I add new journal entry it appears with correct time. I'm not familiar with Python but it seems to add time zone modifier to already correct time, which would give effect I observed (entry time being off by hour difference between nautical and GMT time).

This is in TWoS 2.2.10.


All times are GMT -5. The time now is 07:51 AM.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright © 1995- 2024 Subsim®
"Subsim" is a registered trademark, all rights reserved.